Skip to content

Merge Request and Issue Form Fields

Drew Blessing requested to merge dblessing/gitlab-ce:form_field_changes into master

I'm going a bit out on a limb on this one. This relates to commit eb4320cb. It's something I feel would be useful but I'm open to discussion.

What does this MR do?

This makes it so the assignee and milestone fields (and labels in the case of issues) are only visible to a user that can modify issues or merge requests. (Which means a developer, master and owner can see the fields in an issue and a master and owner can see the fields in a merge request).

Why was this MR needed?

In the commit mentioned above the fields were completely removed from merge requests but left fully intact for issues. This merge request solves 2 issues I see:

  1. Users that normally don't have abilities to modify issues or merge requests could potentially add an assignee or labels without knowledge of what is helpful. This leads to incorrectly assigned items or weird labels that make no sense.
  2. Allow privileged users to complete all steps in one form. As of 6.8 a master or developer has to first create a merge request and then assign a person or add a milestone. This causes an extra step over previous versions of GitLab. It has definitely been a noticeable change in our team workflow.

I don't know the original motivation for removing the fields from merge requests but I have a feeling it could be the first issue mentioned above. If so, I think this is a great solution that meets all needs. I look forward to feedback.

Merge request reports