@DouweM thanks! MR is submitted at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14395
@toupeira Merged and released as v1.6.2! Can you create an MR to pull this into gitlab-ce?
-
fdb3c109 · Merge branch 'feature/plantuml-restructured-text' into 'master'
- ... and 2 more commits. Compare 85d6a8bb...fdb3c109
@smcgivern is out for the week. @DouweM can you take this one please?
@smcgivern can you review this as well?
@brodock ok let me know if you require any further changes in this MR, I'll open the new one once this is merged since I need some of these changes.
Yes, please open a new one for uml
(also consider a MR for any change the Markdown render requires as well)
@brodock sorry forgot to update this, if I understand correctly this MR can be merged as-is with support for plantuml::
only?...
Looks like we can split the effort here in 2 fronts:...
The rendering differences are mostly cosmetic (size/alignment of the diagram) except for caption
....
I don't personally use ReST, so take this with a grain of salt....
@brodock we could maybe avoid that by mentioning the missing support in the documentation (see related MR https://gitlab.com/gitlab-org/gitlab-ce/m...
The uml
directive has some additional options (which do influence the rendering) which we could choose to ignore or implement: https://pypi.python....
Based on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8588, I think we should stick with plantuml
so we can follow the same decision there.
...
I don't have a strong opinion on this. If we use uml
instead, does it creates different expectations on what we should be rendering? Asking this be...