Skip to content
Snippets Groups Projects
username-removed-423116's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

@DouweM thanks! MR is submitted at https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14395

Douwe Maan's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

@toupeira Merged and released as v1.6.2! Can you create an MR to pull this into gitlab-ce?

Douwe Maan's avatar
pushed new tag v1.6.2 at GitLab.org / GitLab Markup
Douwe Maan's avatar
pushed to branch master at GitLab.org / GitLab Markup
Douwe Maan's avatar
accepted merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup
Douwe Maan's avatar
pushed to branch master at GitLab.org / GitLab Markup
Douwe Maan's avatar
pushed new tag v1.6.1 at GitLab.org / GitLab Markup
Douwe Maan's avatar
pushed to branch master at GitLab.org / GitLab Markup
Felipe Artur's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

@smcgivern is out for the week. @DouweM can you take this one please?

Gabriel Mazetto's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

@smcgivern can you review this as well?

username-removed-423116's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

@brodock ok let me know if you require any further changes in this MR, I'll open the new one once this is merged since I need some of these changes.

Gabriel Mazetto's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

Yes, please open a new one for uml (also consider a MR for any change the Markdown render requires as well)

username-removed-423116's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

@brodock sorry forgot to update this, if I understand correctly this MR can be merged as-is with support for plantuml:: only?...

Gabriel Mazetto's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

Looks like we can split the effort here in 2 fronts:...

username-removed-423116's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

The rendering differences are mostly cosmetic (size/alignment of the diagram) except for caption....

username-removed-443319's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

I don't personally use ReST, so take this with a grain of salt....

username-removed-423116's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

@brodock we could maybe avoid that by mentioning the missing support in the documentation (see related MR https://gitlab.com/gitlab-org/gitlab-ce/m...

username-removed-423116's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

The uml directive has some additional options (which do influence the rendering) which we could choose to ignore or implement: https://pypi.python....

Gabriel Mazetto's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

Based on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8588, I think we should stick with plantuml so we can follow the same decision there. ...

Gabriel Mazetto's avatar
commented on merge request !6 "Support PlantUML blocks in reStructuredText" at GitLab.org / GitLab Markup

I don't have a strong opinion on this. If we use uml instead, does it creates different expectations on what we should be rendering? Asking this be...