Skip to content
Snippets Groups Projects
Ben Kochie's avatar
opened issue #36 "Remove process metrics" at GitLab.org / gitlab-monitor
Achilleas Pipinellis's avatar
commented on issue #32 "Provide a single metrics endpoint" at GitLab.org / gitlab-monitor

Oh, yeah I misunderstood then.

username-removed-967900's avatar
commented on issue #32 "Provide a single metrics endpoint" at GitLab.org / gitlab-monitor

Isn't that just a health check? I don't see any metrics in the sample output in that documentation....

Achilleas Pipinellis's avatar
commented on issue #32 "Provide a single metrics endpoint" at GitLab.org / gitlab-monitor

@unixwitch I think what you're asking is covered by https://docs.gitlab.com/ee/user/admin_area/monitoring/health_check.html.

username-removed-506061's avatar
pushed to branch master at GitLab.org / gitlab-monitor
username-removed-506061's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

@stanhu Nope, it will raise an exception that will be caught by the rescue in #execute.

username-removed-117638's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

At least UpdateAllMirrorsWorker and RepositoryUpdateMirrorsWorker only exist in EE

username-removed-117638's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

@stanhu mirroring is EE only right?

Stan Hu's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

Are we excluding these queries from CE?

username-removed-506061's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

@tiagonbotelho Thanks!

username-removed-506061's avatar
deleted branch add-mirror-monitoring at GitLab.org / gitlab-monitor
username-removed-506061's avatar
pushed to branch master at GitLab.org / gitlab-monitor
username-removed-506061's avatar
accepted merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor
username-removed-117638's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

@stanhu if we start needing more queries I will add them as well in a new MR 😄 thanks for the suggestion!

username-removed-117638's avatar
pushed to branch add-mirror-monitoring at GitLab.org / gitlab-monitor
  • 95965b30 · Adds mirror monitoring query
username-removed-506061's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

Just a comment and a Rubocop offense :).

username-removed-506061's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

@tiagonbotelho Could you please add a comment like # GitLab-EE only here, just as a hint.

username-removed-117638's avatar
commented on merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor

The query that I used to write this one was the one generated by Project.mirrors_to_sync(Time.now) (https://gitlab.com/gitlab-org/gitlab-ee/blob/ma...

username-removed-117638's avatar
opened merge request !60 "Adds mirror monitoring query" at GitLab.org / gitlab-monitor
username-removed-117638's avatar
pushed new branch add-mirror-monitoring at GitLab.org / gitlab-monitor