Skip to content
Snippets Groups Projects

Resolve "Gitlab daemon crashing. Omnibus installation (Ubuntu 14.04)"

Merged Nick Thomas requested to merge nick.thomas/gitlab-pages:4-fix-daemonizing into master
All threads resolved!

This MR fixes a collection of small problems thrown up while investigating the named issue:

  • Some error messages are not reported correctly due to using println instead of log.Println
  • Exercise the chrooted mode in the acceptance tests
  • Document the CGO_ENABLED=0 requirement of the chrooted mode
  • Clean up acceptance test running a little
  • Add Go 1.8 to the list of CI builds
  • Run the acceptance tests on all CI builds

Closes #4 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nick Thomas
  • Nick Thomas
  • Nick Thomas added 3 commits

    added 3 commits

    • c8a3cb72 - fixup! Run the tests with gitlab-pages daemonised in the CI environment
    • 5d384638 - fixup! Use fmt/log.Println, not the println builtin
    • dd7b3953 - Rework the acceptance tests to use go test -short as a qualifier

    Compare with previous version

  • Nick Thomas marked as a Work In Progress from nick.thomas/gitlab-pages@c8a3cb72219d8e39a3b7a46dd0b9efbbe353c4e1

    marked as a Work In Progress from nick.thomas/gitlab-pages@c8a3cb72219d8e39a3b7a46dd0b9efbbe353c4e1

  • Nick Thomas unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Nick Thomas added 3 commits

    added 3 commits

    • 934a76c5 - Run the tests with gitlab-pages daemonised in the CI environment
    • 114d0f40 - Document some caveats around the daemon mode
    • 275cafa0 - Rework the acceptance tests to use go test -short as a qualifier

    Compare with previous version

  • assigned to @zj

  • Author Maintainer

    @zj can I get you to review this for me?

  • Nick Thomas added 2 commits

    added 2 commits

    • 8f4b9879 - Run the acceptance test suite on all golang versions
    • a3c94ef6 - Run tests on golang 1.8

    Compare with previous version

  • Zeger-Jan van de Weg
  • Zeger-Jan van de Weg
  • @nick.thomas It feels like this MR is solving a number of issues, instead of only the title. Thats the biggest nitpick I have ;)

  • Nick Thomas resolved all discussions

    resolved all discussions

  • Author Maintainer

    @zj it definitely is doing that, but I don't think I should take the time to split it up into strictly separate parts.

  • Nick Thomas mentioned in commit fbcbce12

    mentioned in commit fbcbce12

  • merged

  • Nick Thomas mentioned in merge request !14 (closed)

    mentioned in merge request !14 (closed)

  • mentioned in issue #46 (closed)

  • Please register or sign in to reply
    Loading