An error occurred while fetching the assigned milestone of the selected merge_request.
Resolve "Gitlab daemon crashing. Omnibus installation (Ubuntu 14.04)"
All threads resolved!
All threads resolved!
This MR fixes a collection of small problems thrown up while investigating the named issue:
- Some error messages are not reported correctly due to using
println
instead oflog.Println
- Exercise the chrooted mode in the acceptance tests
- Document the
CGO_ENABLED=0
requirement of the chrooted mode - Clean up acceptance test running a little
- Add Go 1.8 to the list of CI builds
- Run the acceptance tests on all CI builds
Closes #4 (closed)
Merge request reports
Activity
- Resolved by Nick Thomas
- Resolved by Nick Thomas
- Resolved by Nick Thomas
added 3 commits
- c8a3cb72 - fixup! Run the tests with gitlab-pages daemonised in the CI environment
- 5d384638 - fixup! Use fmt/log.Println, not the println builtin
- dd7b3953 - Rework the acceptance tests to use go test -short as a qualifier
assigned to @zj
@zj can I get you to review this for me?
added 2 commits
- Resolved by Nick Thomas
- Resolved by Nick Thomas
@nick.thomas It feels like this MR is solving a number of issues, instead of only the title. Thats the biggest nitpick I have ;)
assigned to @nick.thomas
@zj it definitely is doing that, but I don't think I should take the time to split it up into strictly separate parts.
mentioned in commit fbcbce12
mentioned in merge request !14 (closed)
mentioned in issue #46 (closed)
Please register or sign in to reply