Fix and clarify redirect HTTP logic

redirect-http seemed to suggest the Pages daemon would redirect from HTTPS to HTTP, but it seems that the opposite was implied.

Fixes issue manifested by https://gitlab.com/gitlab-org/omnibus-gitlab/merge_requests/1348

acceptance_test.go

@@ -38,7 +38,7 @@ func skipUnlessEnabled(t *testing.T) {
 func TestUnknownHostReturnsNotFound(t *testing.T) {
 	skipUnlessEnabled(t)
-	teardown := RunPagesProcess(t, *pagesBinary, listeners, "")
+	teardown := RunPagesProcess(t, *pagesBinary, listeners, "", []string{})
 	defer teardown()
 	for _, spec := range listeners {
@@ -53,7 +53,7 @@ func TestUnknownHostReturnsNotFound(t *testing.T) {
 func TestKnownHostReturns200(t *testing.T) {
 	skipUnlessEnabled(t)
-	teardown := RunPagesProcess(t, *pagesBinary, listeners, "")
+	teardown := RunPagesProcess(t, *pagesBinary, listeners, "", []string{})
 	defer teardown()
 	for _, spec := range listeners {
@@ -66,10 +66,24 @@ func TestKnownHostReturns200(t *testing.T) {
 	}
 }
+func TestHttpRedirect(t *testing.T) {
+	skipUnlessEnabled(t)
+	teardown := RunPagesProcess(t, *pagesBinary, listeners, "",
+		[]string{"-redirect-http=true"})
+	defer teardown()
+
+	rsp, err := GetRedirectPage(t, listeners[0], "127.0.0.1:37001", "project/")
+
+	if assert.NoError(t, err) {
+		defer rsp.Body.Close()
+		assert.Equal(t, http.StatusTemporaryRedirect, rsp.StatusCode)
+	}
+}
+
 func TestPrometheusMetricsCanBeScraped(t *testing.T) {
 	skipUnlessEnabled(t)
 	listener := []ListenSpec{{"http", "127.0.0.1", "37003"}}
-	teardown := RunPagesProcess(t, *pagesBinary, listener, ":42345")
+	teardown := RunPagesProcess(t, *pagesBinary, listener, ":42345", []string{})
 	defer teardown()
 	resp, err := http.Get("http://localhost:42345/metrics")