Note that Netlify provides GitLab integration and doesnt have this bug.
-
15c938ca · Merge branch '85-release-pages-0.6' into 'master'
- ... and 1 more commit. Compare 26a29a44...15c938ca
-
26a29a44 · Merge branch '83-artifact-proxy-changes' into 'master'
- ... and 1 more commit. Compare b322a578...26a29a44
@ayufan OK, addressed and ready for review again.
I prefer this way of doing things because we may add a handler for the /something/else
in the future. Pre-emptively returning a 404 here will break...
It can, and this allows us to remove the matchHost
variable entirely
Yes - they will be passed to the regular pages daemon, which will fail to find a project -
and return 404 as a consequence.
Generally, there's quite an amount of changes. I just have two questions more, than something to complain. Please let me know what do you think @ni...
Does it mean that any request that is group.gitlab.io/-/project/-/something/else
will be processed as the regular pages request?
Can it just be: len(matchHost)-len(a.suffix)
?
OK, I'll do group.gitlab.io/-/subgroup/project/-/jobs/1/artifacts/index.html
- it should be a small, quick change :)