Skip to content
Snippets Groups Projects
username-removed-71700's avatar
commented on issue #9 "Option to remove trailing slash" at GitLab.org / gitlab-pages

Note that Netlify provides GitLab integration and doesnt have this bug.

Nick Thomas's avatar
pushed new tag v0.6.0 at GitLab.org / gitlab-pages
Nick Thomas's avatar
accepted merge request !47 "Release v0.6.0" at GitLab.org / gitlab-pages
Nick Thomas's avatar
closed issue #85 "Release GitLab Pages v0.6.0" at GitLab.org / gitlab-pages
Nick Thomas's avatar
pushed to branch master at GitLab.org / gitlab-pages
Nick Thomas's avatar
closed merge request !29 "adding steps required for build of binary which exist in ci yaml" at GitLab.org / gitlab-pages
Nick Thomas's avatar
opened merge request !47 "Release v0.6.0" at GitLab.org / gitlab-pages
Nick Thomas's avatar
opened issue #85 "Release GitLab Pages v0.6.0" at GitLab.org / gitlab-pages
Kamil Trzcińśki's avatar
accepted merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages
Kamil Trzcińśki's avatar
closed issue #83 "Changes to artifact proxy" at GitLab.org / gitlab-pages
Kamil Trzcińśki's avatar
closed issue #83 "Changes to artifact proxy" at GitLab.org / gitlab-pages
Kamil Trzcińśki's avatar
pushed to branch master at GitLab.org / gitlab-pages
Nick Thomas's avatar
commented on merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages

@ayufan OK, addressed and ready for review again.

Nick Thomas's avatar
commented on merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages

I prefer this way of doing things because we may add a handler for the /something/else in the future. Pre-emptively returning a 404 here will break...

Nick Thomas's avatar
commented on merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages

It can, and this allows us to remove the matchHost variable entirely 👍

Nick Thomas's avatar
commented on merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages

Yes - they will be passed to the regular pages daemon, which will fail to find a project - and return 404 as a consequence.

Kamil Trzcińśki's avatar
commented on merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages

Generally, there's quite an amount of changes. I just have two questions more, than something to complain. Please let me know what do you think @ni...

Kamil Trzcińśki's avatar
commented on merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages

Does it mean that any request that is group.gitlab.io/-/project/-/something/else will be processed as the regular pages request?

Kamil Trzcińśki's avatar
commented on merge request !46 "Rework the artifacts proxy to operate within Pages group domains" at GitLab.org / gitlab-pages

Can it just be: len(matchHost)-len(a.suffix)?

Nick Thomas's avatar
commented on issue #83 "Changes to artifact proxy" at GitLab.org / gitlab-pages

OK, I'll do group.gitlab.io/-/subgroup/project/-/jobs/1/artifacts/index.html - it should be a small, quick change :)