Regression: Files with whitepaces in URL not working (again) for Gitlab + Apache
If a file with spaces in the file name is commited/uploaded etc. it can't be accessed in the Gitlab frontend when using Apache. Instead you get a 400 Bad Request error.
Caused by commit https://gitlab.com/gitlab-org/gitlab-recipes/commit/fbd343f7253aee677bf0726b984b10be2d2418b2
Which btw provides no information why the rewrite rules were actually changed.
This commit reverts the rewrite rules back to a state before the fixes applied by "Christopher Zentgraf" in March/April 2016
Also see the following issue and merge request for further information + the 3-4 commits by "Christopher Zentgraf" in early 2016
Activity
Commit fbd343f7 fix my problem :
network and graph view broken (404) when branch name contains slash ("/") ,like https://gitlab.com/gitlab-org/gitlab-ce/issues/1399
It's there any good idea to fix these two problem(whitepaces in URL and slah in branch name)?
added ~15215 customer labels
@winniehell It looks like the change you made (reverting https://gitlab.com/gitlab-org/gitlab-recipes/merge_requests/47) has broken any folders/files with spaces. I've tested and confirmed this, see http://apache.mrchris.me/root/test/tree/master/test%20spaces%20in%20dir
Spaces broken
RewriteRule .* http://127.0.0.1:8181%{REQUEST_URI} [P,QSA,NE]Spaces working
RewriteRule .* http://127.0.0.1:8181%{REQUEST_URI} [P,QSA]We should find a balance between fixing https://gitlab.com/gitlab-org/gitlab-ce/issues/1399 and this issue.
Oh no, I'm sorry I broke the white space...
Back then, when I made this change (!58 (merged)), I have made extensive testing with slashes in nginx and Apache and it seemed like adding the
NEwas the only option to make both web servers work.I intended to make an encoding test script for Apache but because several people reported that the fix worked for them and since we don't officially support Apache, I didn't spend more time on that.
-
@winniehell No problem! You're right we don't support apache! Thanks for your explanations.
@winniehell, I just found out that slashes work when I turn AllowEncodedSlashes to on, so the NE flag isn't needed anymore. But that can be a security risk, or am I wrong?
Edited by username-removed-433904According to https://security.stackexchange.com/questions/40185/what-are-the-consequences-of-turning-on-apache-allowencodedslashes it shouldn't be a problem to turn it on, if GitLab is handling requests correctly, which I assume it does. Problem is, we need to use Apache because we need Shibboleth to work on our site, which isn't easy to configure using the bundled nginx...
-
I just found out that slashes work when I turn AllowEncodedSlashes to on
@dansou901 The comment in the recipe seems to say the opposite.
Unfortunately, I don't have the time to work on solution for this—I don't even have Apache set up and running. Before making another change to the config I would like to be sure it works with spaces and slashes for all Apache versions that are currently in the recipes.
If anybody can come with a test setup which demonstrates a working config, I'd be very happy to get it merged.
That's because Nodecode is available only on Apache 2.3 and newer according to https://httpd.apache.org/docs/2.4/mod/core.html. I would assume that the config you're linking to will produce an error at apache startup, saying it does not know anything about Nodecode. Can't test that because I've got only a setup for CentOS 7 running. But, if you like to, you can test on https://git.rwth-aachen.de. Just login via Github and ping me, so I can create you a test project. I've turned AllowEncodeSlashes to on there and ditched the NE flags.
This is also being discussed over here:
https://gitlab.com/gitlab-org/gitlab-ce/issues/32585
I'm also running into this issue, will poke around to try and find a working apache config, but don't have much confidence.
Is the core issue that the URL handlers that the web front-end and API are using are treating encoded chars differently?
