Please update vendored github.com/fsouza/go-dockerclient

Please update github.com/fsouza/go-dockerclient in order to support OpenBSD builds. It is the last step before I can package gitlab-ci-multi-runner for OpenBSD 6.0.

I tried to create a MR for it, but running godep on my system keeps removing all files in Godeps/_workspace/src/github.com/fsouza/go-dockerclient/external/ (which is exactly what I want updated). Thanks in advance.

mentioned in merge request !139 (closed)

@frenkel it removes external folder because it was removed in go-dockerclient

mentioned in merge request !192 (closed)

We really need updated "github.com/fsouza/go-dockerclient" due to following FTBFS with newer version:

# gitlab.com/gitlab-org/gitlab-ci-multi-runner/helpers/docker 
src/gitlab.com/gitlab-org/gitlab-ci-multi-runner/helpers/docker/connect.go:21: impossible type assertion: 
        *docker.Client does not implement Client (wrong type for Info method) 
                have Info() (*docker.DockerInfo, error) 
                want Info() (*docker.Env, error) 
src/gitlab.com/gitlab-org/gitlab-ci-multi-runner/helpers/docker/connect.go:70: cannot assign *docker.Client to client (type Client) in multiple assignment: 
        *docker.Client does not implement Client (wrong type for Info method) 
                have Info() (*docker.DockerInfo, error) 
                want Info() (*docker.Env, error) 
src/gitlab.com/gitlab-org/gitlab-ci-multi-runner/helpers/docker/connect.go:78: cannot assign *docker.Client to client (type Client) in multiple assignment: 
        *docker.Client does not implement Client (wrong type for Info method) 
                have Info() (*docker.DockerInfo, error) 
                want Info() (*docker.Env, error) 
src/gitlab.com/gitlab-org/gitlab-ci-multi-runner/helpers/docker/connect.go:86: impossible type assertion: 
        *docker.Client does not implement Client (wrong type for Info method) 
                have Info() (*docker.DockerInfo, error) 
                want Info() (*docker.Env, error) 

It would be great to upgrade "github.com/fsouza/go-dockerclient" to revision 8fd726ff652fdc430907f7ba90187458f0617221 (or higher).

This would be very helpful in order to introduce gitlab-ci-multi-runner to Debian. Thanks.

Alternatively one can consider switching to github.com/docker/engine-api...

It would be great if this issue could be prioritised please.

@onlyjob We're thinking on replacing current docker client with the official one that you've also posted above. We have plans to work on this in 1.5 and I hope it will happen :)

Thanks, Tomasz. :)

mentioned in merge request !246 (closed)

mentioned in merge request !185 (closed)

Since we're in the progress of migrating to an official docker GO library - I'm closing this issue :)

Status changed to closed

Which release will have that change?

There is a MR (!282 (closed)) which was planned for v1.6. However github.com/docker/engine-api is already deprecated and we've started work on changing this to github.com/docker/docker/client - !301 (merged)

I hope it will be finished soon. If this will be v1.6? I'm not sure. But in such case it should be in v1.7 :)