Building for Illumos / Solaris 10

@kingloud we could update our vendored logrus to 0.10, but !301 (merged) would be required as well because go-dockerclient also vendors its own logrus, and in our vendored version of go-dockerclient it appears to be a snapshot of 0.9, taken before the Solaris fixes.

I don't have much Solaris experience, so I don't know if there would be additional problems on top of that :(.

I'll prepare an MR that updates logrus to latest, anyway. If we can get that merged, I'll rebase !301 (merged) on top of it and you could try compiling that for Solaris. Sound good?

Thanks @nick.thomas - That would be great.

Mentioned in merge request !344 (merged)

@kingloud OK, keep an eye on !344 (merged)

Are you just looking to get a solaris runner for yourself, or is this a packaging attempt for a solaris-based distribution?

It's just for myself to test some tools we make specifically for solaris-based systems

Added ~58730 label

I just took another stab at cross compiling for solaris on the latest branch, but had no luck. It is most certainly something I'm messing up with golang

Building with

GOOS=solaris GOARCH=amd64 make install

Resulting output:

WARNING: No swap limit support
WARNING: No swap limit support
make: Circular out/docker/prebuilt-x86_64.tar.xz <- executors/docker/bindata.go dependency dropped.
make: Circular out/docker/prebuilt-arm.tar.xz <- executors/docker/bindata.go dependency dropped.
go install --ldflags="-X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.NAME=gitlab-ci-multi-runner -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.VERSION=9.1.0~beta.55.ge83891d -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.REVISION=e83891d -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.BUILT=2017-04-06T14:36:43-07:00 -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.BRANCH=master"
# gitlab.com/gitlab-org/gitlab-ci-multi-runner/vendor/github.com/Sirupsen/logrus
vendor/github.com/Sirupsen/logrus/terminal_solaris.go:13: undefined: unix.IoctlGetTermios
vendor/github.com/Sirupsen/logrus/terminal_solaris.go:13: undefined: unix.TCGETA
Makefile:200: recipe for target 'install' failed

@kingloud Can you check how this behaves with newest logrus version?

This will update logrus to v0.11.5 version:

$ cd $GOPATH/src/github.com/Sirupsen/logrus/
$ git fetch --tags
$ git checkout v0.11.5
$ cd $GOPATH/src/gitlab.com/gitlab-org/gitlab-ci-multi-runner/
$ govendor update github.com/Sirupsen/logrus

After this try to compile. If it will work, then it will be a matter of updating 'logrus` and checking that everything still works :)

Should I have an existing $GOPATH/src/github.com/Sirupsen/logrus/ directory?

I had to go get github.com/Sirupsen/logrus in order t build one.

I executed the above steps ( also had to go get -u github.com/kardianos/govendor ) but the compiling result was the same.

I would not rule out my environment as being at fault here as I am a golang novice.
Take this feedback with a gain of salt

Ah, right. I have it, you may not. go get github.com/Sirupsen logrus is a requirement at this point :)

It looks that the problem is in too old golang.org/x/sys/unix which doesn't contain unix.IoctlGetTermios and unix.TCGETA.

Please do the following (I assume that you still have not commited results of govendor update ... described by me above):

$ git checkout -- vendor
$ go get -u golang.org/x/sys/unix
$ cd $GOPATH/src/golang.org/x/sys/unix
$ git checkout master
$ cd $GOPATH/src/gitlab.com/gitlab-org/gitlab-ci-multi-runner/
$ govendor update golang.org/x/sys/unix

This will update golang.org/x/sys/unix. Then try to compile :)

Ah yes, that does indeed fix the logstash failure :)

However it then triggers a whole host of other issue in zip and shell

# gitlab.com/gitlab-org/gitlab-ci-multi-runner/helpers/archives
helpers/archives/zip_extra.go:72: undefined: createZipUIDGidField
helpers/archives/zip_extra.go:112: undefined: processZipUIDGidField
# gitlab.com/gitlab-org/gitlab-ci-multi-runner/helpers/cli
helpers/cli/log_level.go:38: undefined: watchForGoroutinesDump
# gitlab.com/gitlab-org/gitlab-ci-multi-runner/executors/shell
executors/shell/executor_shell.go:60: undefined: helpers.KillProcessGroup
executors/shell/executor_shell.go:76: undefined: helpers.SetProcessGroup
executors/shell/executor_shell.go:77: undefined: helpers.KillProcessGroup

Thanks for the help @tmaczukin ! I'll take a look at this a little later and see if this effort is worth continuing to explore. cheers!

So I think i got it working on solaris - many thanks to the contributors to this thread in getting me on my way.

The undefined exceptions are due to several _unix.go sources not listing solaris amongst them, as shown in the following diff...

diff --git a/commands/config_unix.go b/commands/config_unix.go
index 173785e..1460941 100644
--- a/commands/config_unix.go
+++ b/commands/config_unix.go
@@ -1,4 +1,4 @@
-// +build linux darwin freebsd openbsd
+// +build linux darwin freebsd openbsd solaris

 package commands

diff --git a/helpers/archives/zip_extra_unix.go b/helpers/archives/zip_extra_unix.go
index c066693..4af1725 100644
--- a/helpers/archives/zip_extra_unix.go
+++ b/helpers/archives/zip_extra_unix.go
@@ -1,4 +1,4 @@
-// +build linux darwin freebsd openbsd
+// +build linux darwin freebsd openbsd solaris

 package archives

diff --git a/helpers/cli/dump_unix.go b/helpers/cli/dump_unix.go
index f4fc57a..5c3a316 100644
--- a/helpers/cli/dump_unix.go
+++ b/helpers/cli/dump_unix.go
@@ -1,4 +1,4 @@
-// +build darwin dragonfly freebsd linux netbsd openbsd
+// +build darwin dragonfly freebsd linux netbsd openbsd solaris

 package cli_helpers

diff --git a/helpers/process_group_unix.go b/helpers/process_group_unix.go
index 3faad62..c329749 100644
--- a/helpers/process_group_unix.go
+++ b/helpers/process_group_unix.go
@@ -1,4 +1,4 @@
-// +build darwin dragonfly freebsd linux netbsd openbsd
+// +build darwin dragonfly freebsd linux netbsd openbsd solaris

 package helpers

The make command still failed (the linker appeared to not work, perhaps due to a malformed ldflags entry), so I simply ran the "go install" command directly and the resulting binary appears to work (at least I got one build running with it so far).

Here's a command history if it helps..

cd /opt/gitlab-runner
git clone https://gitlab.com/gitlab-org/gitlab-ci-multi-runner.git
cd gitlab-ci-multi-runner/
git checkout 1-8-stable
go get -u golang.org/x/sys/unix
cd $GOPATH/src/golang.org/x/sys/unix
git checkout master
cd $GOPATH/src/gitlab.com/gitlab-org/gitlab-ci-multi-runner/
$GOPATH/bin/govendor update golang.org/x/sys/unix

# add 'solaris' to the end of the "+build" hint for the following files (or apply the above patch via git)
vi ./helpers/process_group_unix.go
vi ./commands/config_unix.go
vi ./helpers/archives/zip_extra_unix.go
vi ./helpers/cli/dump_unix.go

GOOS=solaris GOARCH=amd64 gmake install
# This failed for me with a complaint about link not having the right parameters. It could be because one of the -X parameters appeared to be malformed (?)
go install --ldflags="-X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.NAME=gitlab-ci-multi-runner -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.VERSION=1.8.8~beta.0.gddb7a81 -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.REVISION=ddb7a81 -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.BUILT=2017-07-08T22:36:37%:z -X gitlab.com/gitlab-org/gitlab-ci-multi-runner/common.BRANCH=1-8-stable"

$GOPATH/bin/gitlab-ci-multi-runner --help

Building for Illumos / Solaris 10

Designs

Child items 0

Activity

Admin message

Admin message

Building for Illumos / Solaris 10

Activity