Invalid bind mount spec running docker exec on windows

Mentioned in issue #1748 (closed)

I think this is due to a bug in the volume string splitting on windows where ":" (colon) is a part of the path. Line 341 in executor_docker.go:addVolume() method splits the volume string by ":". Unfortunately, that splits "C" from the rest of the volume string...

Added executordocker osWindows labels

Thanks for the report @jnaous - I'll see if we can work out how to get that fixed.

Have you encountered any other issues with Docker for Windows? I notice you're connecting over TCP, presumably due to the lack of npipe support?

Thanks! Yes that's right, no npipe support.

I seem to have similar if not same issue on Windows 7 using gitlab runner 1.11.0 and docker 1.12.3. Any news on this?

Should I describe my specific issue here in this thread or open a new ticket?

Same issue here. I'm using docker on Windows 10 in combination with virtualbox. Would be really nice if we can get any Help. Thanks in advance!

d:\Code\Git\horizon\horizon gitlab-ci-multi-runner --debug exec docker build
Runtime platform                                    arch=amd64 os=windows revision=a67a225 version=1.11.1
Running with gitlab-ci-multi-runner 1.11.1 (a67a225)
  on  ()
Shell configuration: environment: []
dockercommand:
- sh
- -c
- "if [ -x /usr/local/bin/bash ]; then\n\texec /usr/local/bin/bash \nelif [ -x /usr/bin/bash
  ]; then\n\texec /usr/bin/bash \nelif [ -x /bin/bash ]; then\n\texec /bin/bash \nelif
  [ -x /usr/local/bin/sh ]; then\n\texec /usr/local/bin/sh \nelif [ -x /usr/bin/sh
  ]; then\n\texec /usr/bin/sh \nelif [ -x /bin/sh ]; then\n\texec /bin/sh \nelse\n\techo
  shell not found\n\texit 1\nfi\n\n"
command: bash
arguments: []
passfile: false
extension: ""
  build=1 project=1
Using Docker executor with image registry.apps.rasos.co.uk/shared/mkdocs:stable ...
Applying docker.Client transport fix: &{false 0xc0421fe0f0 0xc042247080 0xc04200dea0 tcp://192.168.99.100:2376 0xc0421ea700 0xc0421edb60 [1 18] [] [] <nil>}  host=tcp://192.168.99.100:2376
Creating build volume...                            build=1 project=1
Looking for prebuilt image gitlab/gitlab-runner-helper:x86_64-a67a225 ...  build=1 project=1
Starting cache container a7dbff8ee41d3718ad8feb4791cb146cd2129f032cf3fe4ed888b16106131f1b ...  build=1 project=1
Waiting for cache container a7dbff8ee41d3718ad8feb4791cb146cd2129f032cf3fe4ed888b16106131f1b ...  build=1 project=1
Waiting for container a7dbff8ee41d3718ad8feb4791cb146cd2129f032cf3fe4ed888b16106131f1b ...  build=1 project=1
Creating services...                                build=1 project=1
Creating user-defined volumes...                    build=1 project=1
Using host-based d for /builds/project-1/\Code\Git\horizon\horizon:d:\Code\Git\horizon\horizon:ro ...  build=1 project=1
Starting Docker command...                          build=1 project=1
Looking for prebuilt image gitlab/gitlab-runner-helper:x86_64-a67a225 ...  build=1 project=1
No credentials found for docker.io                  build=1 project=1
Looking for image sha256:f726c0624e90b35e4d909ff2ec728538ca22324505f59a7c4f7902d9ed8ea5c6 ...  build=1 project=1
Removed container runner--project-1-concurrent-0-predefined with No such container: runner--project-1-concurrent-0-predefined  build=1 project=1
Creating container runner--project-1-concurrent-0-predefined ...  build=1 project=1
Removed container a7dbff8ee41d3718ad8feb4791cb146cd2129f032cf3fe4ed888b16106131f1b with <nil>  build=1 project=1
Closed all idle connections for docker.Client: &{false 0xc0421fe1b0 0xc042247080 0x2f6bd80 tcp://192.168.99.100:2376 0xc0421ea700 0xc0421edb60 [1 18] [1 25] [1 18] <nil>}
ERROR: Preparation failed: API error (500): invalid bind mount spec "d:/builds/project-1/\\Code\\Git\\horizon\\horizon:d:\\Code\\Git\\horizon\\horizon:ro": invalid volume specification: 'd:/builds/project-1/\Code\Git\horizon\horizon:d:\Code\Git\horizon\horizon:ro'

mentioned in issue #2254

Any updates on this ? I'm encountering this issue as well on Windows 10. I guess this issue prevents any windows user to debug CI/CD pipelines locally.

Open for a PR otherwise ?

Windows 10 user here as well. Running into the same issue. Tried using Runner version 9.1.3 and Docker 10743.

I was trying to setup local debug pipelines to (pre)test a push

Got the same issue on Windows7 with Docker Toolbox v17.04.0-ce. But I guess this is really a gitlab-runner issue, rather than anyting else, isn't it ?

I've made some research and found that docker executor will not properly run on Windows environment. There are a lot of places where code binds on unix (volumes paths for example) Currently I'm going to contribute some fixes but can't predict when runner will be fully compatible with Windows

@andrew.nestorenko I'm trying to work on just this issue, but I'm having trouble testing.

https://gitlab.com/cdhunt/gitlab-ci-multi-runner/commits/issues/1775

I was able to get past the addVolume issue and now I'm stuck on prebuilt assets.

ERROR: Preparation failed: Unsupported architecture: x86_64: "Asset prebuilt-x86_64.tar.xz not found"```

TODO:
1. Create dockerfile to build a nanoserver x86_64 image
1. Update getPrebuiltImage() to look for win image based on runtime.GOOS
1. Watch gitlab-ci-multi-runner.exe grow to over 1GB :frowning2:

@cdhunt You will probably face a problem with building prebuild artifact for Windows. I've already tried to do it and if you review Makefile you can find that prebuild tar archive it is a result of docker export -o out/file.tar <container-id> But unfortunately docker on windows does not support export command... I had to use docker save but it's just different thing (export - it's about CONTAINER, save - about IMAGE)

So it would be tricky to reproduce all things that restoring prebuild images to container on windows...

@andrew.nestorenko I'm thinking it's not practical to package the binary image with the runner exe anyway. The Linux prebuilt archives are < 9MB whereas the smallest Windows image would be > 900MB and probably most users would at least want Server Core. My suggestion would be to publish the prebuilt Windows images on Docker hub. That would mean we'd likely need to add a docker pull to the install code path. The dockerfile only has two configuration lines.

RUN apk add --no-cache bash ca-certificates git miniperl \ 
	&& ln -s miniperl /usr/bin/perl

COPY ./ /usr/bin

We don't need bash and I don't think we need to update/change ca-certs. We would need Git for Windows. I don't know what the purpose of miniperl is.

I'm not sure what $PWD is for the COPY command.

mentioned in issue #2331

mentioned in issue #1729

@cdhunt prebuild nanoserver with gitlab-runner-helper.exe and Mingit is ~270MB (already packed with xz) Git for Windows could be replaced with MinGIT (really tiny git build (just 20 MB)

Downloading this packages could be a part of register process or build could be done right on machine where runner is now.

You may face another issue. Inside Shell directory you can find different supported shells, but Powershell has PassFile: true (line 230) and in executor_docker.go there is a condition like

if s.BuildShell.PassFile {
		return errors.New("Docker doesn't support shells that require script file")
	}

@tmaczukin could you please explain this behavior?

The issue I submitted (2232) appears to be duplicate for this issue, now that it is further along. https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/2232

@andrew.nestorenko do you already have a dockerfile for this?

@cdhunt I had a dockerfile, but was unable to test it properly. Can't find it right now :( Did you figure out what PassFile: true param mean?

I'm working on the assumption that it should be false as part of this commit, but there are several other issues to address before I can even test that. https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/commit/62ebf0c8084c9bc44038df488024bdbeb012aaad

mentioned in issue #2232 (closed)

mentioned in issue #2176

mentioned in issue #312 (closed)

mentioned in issue #2588

FWIW, we're looking into the approach of creating a new executor for Windows containers and not trying to "fix" the existing docker_executor. I started an issue list on my personal fork to try and codify the list of required changes.

https://gitlab.com/cdhunt/gitlab-ci-multi-runner/issues

@cdhunt Can we somehow assist into building executor_windows_containers. I think that you may be right in that approach. Do issues reflect all things that have to be fixed on Docker for Windows?

@ayufan I'd love some help. I'm pretty sure the list is missing some items, but I don't understand the runner code as a whole enough to enumerate them yet. I don't yet know how to wire up a new executor. I don't know for sure how to handle the base image — the new release of Nano server is probably small enough to ship with the binary, but the Windows Docker engine doesn't support container Export. Pulling from Docker Hub will work for some, but I'm sure not everyone creates runners with Internet access. However, for the purpose of building an alpha release, we can just assume the image exists locally already.

I'm working in https://gitlab.com/cdhunt/gitlab-ci-multi-runner/tree/feature/windows-docker-executor.

I think that we should assume that image is distributed externally, as we do for Kubernetes and allow to use one stored internally.

@cdhunt Could you create a separate meta issue to track everything that we need to do? I think that we should help from GitLab side doing that and make Windows experience to be on-pair.

cc @bikebilly

Just a new single issue with bullets for each item?

Created #2609.

mentioned in issue #2609

Invalid bind mount spec running docker exec on windows

Designs

Child items ...

Activity

Admin message

Admin message

Invalid bind mount spec running docker exec on windows

Activity