Runner says "Cache extracted successfully" if cache-extractor gets 404 response for cache URL

Summary

commands/helpers/cache_extractor.go defines a gitlab-runner cache-extractor command that is used to pull and extract the cache from a remote URL. If thst URL returns a 404 response, the command finishes with an exit code of 0.

shells/abstract.go takes that to mean that the cache extraction has successfully completed, and outputs a message to that effect, confusing matters.

Steps to reproduce

Just run the command with http://localhost/notexist.zip or so

Actual behavior

Build output on cache miss looks like:

Extracting cache
Checking cache for master...
Successfully extracted cache

Expected behavior

Extracting cache
Checking cache for master...
Cache not found!

I'm having the same issue. Did you find any workaround or fix for this @nick.thomas ?

As this is a up-for-grabs issue, I'd like to work on it!

mentioned in merge request !429 (merged)

I'm having an issue with cache and if I understand this issue correctly this might be the culprit. I'm building a ruby project and I want to cache dependencies across builds. Here's my CI config:

rspec:
  image: ruby:2.3.1
  stage: test
  cache:
    key: "$CI_PROJECT_NAME"
    paths:
      - vendor
  variables:
    BUNDLE_PATH: "$CI_PROJECT_DIR/vendor/bundle"
    BUNDLE_BIN: "$CI_PROJECT_DIR/vendor/bundle/bin"
  before_script:
    - bundle config
    - test -d vendor && find vendor -type d -maxdepth 3
    - bundle check || bundle install -j4 --deployment
  script:
    - bundle show
    - test -d vendor && find vendor -type d -maxdepth 3

The output of test -d vendor && find vendor -type d -maxdepth 3 in before script is always empty even if I always find the message Successfully extracted cache in the build log.

Now I understand that cache is provided as best effort service, but it would be very useful to have an indicator in the build output to understand if cache is used or not to understand if my configuration is fine.

I've used this config in other projects and it worked for a while but now cached dependencies are never present and I don't know if I'm doing something wrong or if cache is not present.

changed milestone to %v1.10

@fabn I'm having the same issue with a php project using composer where I get all success messages, but my expected cached folder are empty on extraction. Looking forward for a fix, using the shared runners offered by gitlab.com

changed milestone to %v1.11

added To Do label

mentioned in issue #2291 (closed)

mentioned in issue #1621

assigned to @MrTrustor

closed via merge request !429 (merged)