Skip to content

charset in content-type breaks the runner

Summary

The runner does not accept JSON response, if charset is present. Unable to register.

Steps to reproduce

Enable charset marking in nginx.conf and attempt to register a runner (see logs for details).

    charset utf-8;
    charset_types * utf-8;

Actual behavior

The application exits with fatal error. The runner appears on the runners page, but never succeeds to connect.

Expected behavior

The application should accept the content-type and use the response.

Relevant logs and/or screenshots

# gitlab-runner register
Running in system-mode.

Please enter the gitlab-ci coordinator URL (e.g. https://gitlab.com/):
https://gitlab.example.com/ci
Please enter the gitlab-ci token for this runner:
abcdef123456
Please enter the gitlab-ci description for this runner:
[main]:
Please enter the gitlab-ci tags for this runner (comma separated):
main
ERROR: Registering runner... failed                 runner=abcdef12 status=Server should return application/json. Got: application/json; charset=utf-8
PANIC: Failed to register this runner. Perhaps you are having network problems

Environment description

The gitlab installation is behind a nginx reverse proxy. Manually downloaded 1.9.0 amd64 deb for Debian Stretch.

Used GitLab Runner version

Version:      1.9.0
Git revision: 82714ae
Git branch:   1-9-stable
GO version:   go1.7.4
Built:        Thu, 22 Dec 2016 16:35:13 +0000
OS/Arch:      linux/amd64