register --docker-image needs to be before --docker-tlsverify

Summary

gitlab-ci-multirunner register --docker-tlsverify X --docker-image Y fails with "PANIC: The docker-image needs to be entered"

Steps to reproduce

Try to register a docker or docker-machine runner, and specify --docker-tlsverify before --docker-image

Actual behavior

PANIC: The docker-image needs to be entered

Expected behavior

Order should not matter

Used GitLab Runner version

(docker-compose output)

runner_1        | Version:      9.0.2
runner_1        | Git revision: fa8b86d
runner_1        | Git branch:   9-0-stable
runner_1        | GO version:   go1.7.5
runner_1        | Built:        Thu, 06 Apr 2017 17:05:19 +0000
runner_1        | OS/Arch:      linux/amd64
runner_1        | Running in system-mode.   

closed

The --docker-tlsverify flag is a boolean. CLI library used by Runner requires to use such flag without value (so flag omitted is set to false and flag present is set to true) or to set the value with = sign.

These examples will be working properly:

$ gitlab-runner register --docker-tlsverify --docker-image alpine [...]
$ gitlab-runner register --docker-tlsverify=true --docker-image alpine [...]
$ gitlab-runner register --docker-image alpine --tls-verify [...]
$ gitlab-runner register --docker-image alpine --tls-verify=true [...]
$ gitlab-runner register --docker-image alpine [...]
$ gitlab-runner register --docker-tlsverify=false --docker-image alpine [...]
$ gitlab-runner register --docker-image alpine --tls-verify=false [...]

But these will raise panic because CLI library is failing on options parsing:

$ gitlab-runner register --docker-tlsverify true --docker-image alpine [...]
$ gitlab-runner register --docker-tlsverify false --docker-image alpine [...]
$ gitlab-runner register --docker-image alpine --docker-tlsverify true [...]
$ gitlab-runner register --docker-image alpine --docker-tlsverify false [...]

In your case you should call the command as: gitlab-ci-multirunner register --docker-tlsverify=X --docker-image Y and it will work.

The root cause is in used library, which is quite old and probably in newest version this bug is fixed. But that problem is already tracked in #1904 so I'm closing this as a duplicate :)