gitlab-runner cli | --env does not work

Summary

If i use the --env option of the gitlab-runner register cli the env options are not registered in the executed docker images.

Steps to reproduce

Register the runner with and start it.

gitlab-runner register \
	--executor 'docker' \
	--docker-image 'alpine' \
	--docker-network-mode $DOCKER_NETWORK \
	--pre-clone-script 'git config --global http.sslVerify false;' \
	--docker-disable-cache \
	--docker-wait-for-services-timeout "30" \
	--docker-volumes "/var/run/docker.sock:/var/run/docker.sock" \
	--docker-pull-policy "always" \
	--docker-tlsverify "false" \
	--env "GIT_SSL_NO_VERIFY=1" \
	--env "HTTP_PROXY=$HTTP_PROXY" \
	--env "HTTPS_PROXY=$HTTPS_PROXY" \
	--env "NO_PROXY=$NO_PROXY"
...

Used env variables are all set locally.

Actual behavior

Runner Debug Output

runners:
- name: Runner
    ...
  runnersettings:
    executor: docker
    buildsdir: ""
    cachedir: ""
    environment: []
    preclonescript: git config --global http.sslVerify false;
    prebuildscript: ""
    postbuildscript: ""

Expected behavior

Runner Debug Output

runners:
- name: Runner
    ...
  runnersettings:
    executor: docker
    buildsdir: ""
    cachedir: ""
    environment: [GIT_SSL_NO_VERIFY=1, HTTP_PROXY=1..., HTTPS_PROXY=1..., NO_PROXY=...]
    preclonescript: git config --global http.sslVerify false;
    prebuildscript: ""
    postbuildscript: ""

Environment description

GitLab: 9.1.2 (latest)

Runner: gitlab/gitlab-runner:alpine-v9.1.1 (latest)

For people with the same problem as me, you can use this line as workaround.

--pre-build-script "export HTTP_PROXY=$HTTP_PROXY; export HTTPS_PROXY=$HTTPS_PROXY; export NO_PROXY=$NO_PROXY;"

@PhilippHeuer Thanks for the report and the detailed output provided for the commands and GitLab product versions.

@nick.thomas Have you seen this issue before?

added ~58730 executordocker labels

@PhilippHeuer the problem is in --docker-tlsverify "false", boolean flags are not supposed to receive parameters. If present it's true otherwise if false.

With you parameters, you are setting docker-tlsverify to true and all the following parameters are being ignored because false is interpreted as an argument of the register command.

@nolith good catch! Yes, you need to set boolean arguments like --docker-tlsverify=false, i.e., no spaces.

So there's no bug here with the runner itself, but I wonder if this points to a docfix we need to make, or perhaps we should consider trying to fix boolean command-line options so they work as expected. Wdyt @tmaczukin ?

Long shot: perhaps this is fixed for us in an up-to-date urfave/cli?

@nick.thomas I would first try to update the cli library, as it starts to bite us here and there. If this will still not fix the problem, then we should probably update documentation and think on making a fix in the cli library and pushing it upstream.

I think we can close this issue now. Upgrading the cli library is already tracked in #1904

closed

@tmaczukin it's how the flag package work, so updating urfave/cli is a long-shot possibility. We can try it though