gitlab-runner merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests2017-09-14T19:00:38Zhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/679Mark exec and service-management commands as DEPRECATED2017-09-14T19:00:38ZTomasz Maczukintomasz@gitlab.comMark exec and service-management commands as DEPRECATED## What does this MR do?
Adds deprecation notices for:
- `exec` command
- service-related commands (`start|stop|restart|status|install|uninstall`)
## Does this MR meet the acceptance criteria?
- [x] Documentation created/upd...## What does this MR do?
Adds deprecation notices for:
- `exec` command
- service-related commands (`start|stop|restart|status|install|uninstall`)
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [-] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Closes #271010.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/677Add Release Checklist template2017-10-06T11:00:32ZTomasz Maczukintomasz@gitlab.comAdd Release Checklist templateAdds a `Release Checklist` issue template, which will be used to plan releases.
Closes #2252Adds a `Release Checklist` issue template, which will be used to plan releases.
Closes #225210.0Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/676add install VirtualBox step & improve VM setup details2017-09-12T09:48:59Zusername-removed-5332add install VirtualBox step & improve VM setup details## What does this MR do?
Improve details on setting up VirtualBox executor## What does this MR do?
Improve details on setting up VirtualBox executorhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/672Specify an explicit length for git rev-parse --short to avoid conflicts when run2017-09-06T18:27:08Zusername-removed-782874Specify an explicit length for git rev-parse --short to avoid conflicts when run## What does this MR do?
In three places, this specifies an explicit length when using `git rev-parse --short`. By doing so, it ensures that the revision hash used in builds will be consistent regardless of who is running the build and ...## What does this MR do?
In three places, this specifies an explicit length when using `git rev-parse --short`. By doing so, it ensures that the revision hash used in builds will be consistent regardless of who is running the build and in what environment.
## Why was this MR needed?
Issue #2735 provides a case where all pipelines fail to run with the kubernetes executor running on macOS due to mismatched hashes.
## Are there points in the code the reviewer needs to double check?
I chose a length of 8 for for the hashes. Whether or not that's the right choice is up to the project maintainers. It might also make sense to have it be a global configuration variable for the project.
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [X] All builds are passing
- [X] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
* #2735https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/670Add link to Kubernetes executor details2017-09-08T16:23:57Zusername-removed-5332Add link to Kubernetes executor details## What does this MR do?
Add link to additional Kubernetes configuration details
Replace https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/merge_requests/662## What does this MR do?
Add link to additional Kubernetes configuration details
Replace https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/merge_requests/662https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/668Document how to define default image to run using Kubernetes executor2017-09-06T08:38:24Zusername-removed-5332Document how to define default image to run using Kubernetes executor## What does this MR do?
show how to define default image to run using with Kubernetes## What does this MR do?
show how to define default image to run using with Kuberneteshttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/664Add handling of non-existing images for Docker >= 17.072017-10-04T11:35:06ZTomasz Maczukintomasz@gitlab.comAdd handling of non-existing images for Docker >= 17.07## What does this MR do?
Fixes test failures like https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/-/jobs/30787332 introduced by change in Docker.
## Why was this MR needed?
## Are there points in the code the reviewer needs to do...## What does this MR do?
Fixes test failures like https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/-/jobs/30787332 introduced by change in Docker.
## Why was this MR needed?
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?10.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/661Rename to gitlab runner2017-09-12T09:49:27ZTomasz Maczukintomasz@gitlab.comRename to gitlab runner> ## WARNING
>
> This MR introduces a change that - if merged in wrong moment - is breaking a lot of things. Don't merge this without getting familiar with #1195 and a migration plan that will be added there!
## What does this MR d...> ## WARNING
>
> This MR introduces a change that - if merged in wrong moment - is breaking a lot of things. Don't merge this without getting familiar with #1195 and a migration plan that will be added there!
## What does this MR do?
Renames all usages of `gitlab-ci-multi-runner` to `gitlab-runner` (which includes changes in DEB/RPM packages configuration etc.)
## Why was this MR needed?
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Part of #119510.0Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/660Adds EmptyDir support for k8s volumes2017-09-29T13:40:49Zusername-removed-84795Adds EmptyDir support for k8s volumes## What does this MR do?
It adds supports for EmptyDir to the kubernetes executor
## Why was this MR needed?
When using gitlab-runner, you might want to be able to provide tmpfs for services, for example running a database service dur...## What does this MR do?
It adds supports for EmptyDir to the kubernetes executor
## Why was this MR needed?
When using gitlab-runner, you might want to be able to provide tmpfs for services, for example running a database service during your tests, instead of a slow
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
This MR fixes #2575 https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/659Update README.md2017-08-28T11:51:37ZShinya MaedaUpdate README.md## What does this MR do?
This MR updates outdated README.md
## Why was this MR needed?
Current README.md is outdated.
## Are there points in the code the reviewer needs to double check?
Is this better?
## Does this MR meet the acce...## What does this MR do?
This MR updates outdated README.md
## Why was this MR needed?
Current README.md is outdated.
## Are there points in the code the reviewer needs to double check?
Is this better?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/658Clarify that cloning a runner could be considered an attack vector2017-09-18T11:39:44ZLee MatosClarify that cloning a runner could be considered an attack vectorThis generated from a customer having confusion about two runners having the same token and the security implications here. I've clarified in this MR. <3This generated from a customer having confusion about two runners having the same token and the security implications here. I've clarified in this MR. <3https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/657Lock runners to project by default2017-09-14T22:00:47ZZeger-Jan van de Wegzegerjan@gitlab.comLock runners to project by default## Does this MR meet the acceptance criteria?
- [X] Documentation created/updated
- Tests
- [-] Added for this feature/bug
- [x] All builds are passing
## What are the relevant issue numbers?
gitlab-org/gitlab-ci-multi-runner#2615## Does this MR meet the acceptance criteria?
- [X] Documentation created/updated
- Tests
- [-] Added for this feature/bug
- [x] All builds are passing
## What are the relevant issue numbers?
gitlab-org/gitlab-ci-multi-runner#261510.0Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/656Update cli dep2017-08-22T14:27:46ZZeger-Jan van de Wegzegerjan@gitlab.comUpdate cli dep## What does this MR do?
Update the dependency, it was moved to another namespace. This make getting a newer version easier too.
## Are there points in the code the reviewer needs to double check?
That it still works as expected
## D...## What does this MR do?
Update the dependency, it was moved to another namespace. This make getting a newer version easier too.
## Are there points in the code the reviewer needs to double check?
That it still works as expected
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [-] Added for this feature/bug
- [ ] All builds are passing
## What are the relevant issue numbers?
Might help with https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/1904, but needs to be done anyway10.0Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/655Fix variable file permission2017-09-12T15:45:18ZAlessio CaiazzaFix variable file permission## What does this MR do?
Prevent kubernetes executor failure when the image does not run as `root`.
## Why was this MR needed?
The user problem is described in #2570
The problem is that stages running with the `Predefined` command r...## What does this MR do?
Prevent kubernetes executor failure when the image does not run as `root`.
## Why was this MR needed?
The user problem is described in #2570
The problem is that stages running with the `Predefined` command run as `root` and if a variable is dumped to the disk, like `CI_SERVER_TLS_CA_FILE`, it will be root owned on the following stages.
## Are there points in the code the reviewer needs to double check?
Personally I don't like this solution, but it's a fast and general fix to the problem.
In case of `CI_SERVER_TLS_KEY_FILE` we will end up exposing a key file with global readability, which may not be a problem with docker and kubernetes but it's very dangerous with the shell runner.
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Closes #257010.0Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/654Add support for tmpfs on the job container.2017-08-21T07:27:45Zusername-removed-89670Add support for tmpfs on the job container.## What does this MR do?
For the sake of completeness, add TMPFS support for the job container. This completes @mion00 work on https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/merge_requests/605.
## Why was this MR needed?
S...## What does this MR do?
For the sake of completeness, add TMPFS support for the job container. This completes @mion00 work on https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/merge_requests/605.
## Why was this MR needed?
See #1454
## Are there points in the code the reviewer needs to double check?
No.
## Does this MR meet the acceptance criteria?
- [X] Documentation created/updated
- Tests
- [X] Added for this feature/bug
- [X] All builds are passing
- [X] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
#1454https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/653Oxford comma, and improve wording2017-08-18T18:13:14ZMark PundsackOxford comma, and improve wording> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
## Why was this MR needed?
## Are there points in the code the reviewer needs to...> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
## Why was this MR needed?
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/650fix I am not sure section link2017-08-16T12:07:30Zusername-removed-528029fix I am not sure section link
## What does this MR do?
## Why was this MR needed?
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [ ] Add...
## What does this MR do?
## Why was this MR needed?
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/649Adding tzdata by default to avoid OffPeakPeriods timezone error2017-08-16T18:07:49Zusername-removed-609281Adding tzdata by default to avoid OffPeakPeriods timezone error## What does this MR do?
Adds the tzdata package to the Alpine Dockerfile so that the container doesn't fail instantly with the [OffPeakPeriods timezone error](https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/master/docs/faq/...## What does this MR do?
Adds the tzdata package to the Alpine Dockerfile so that the container doesn't fail instantly with the [OffPeakPeriods timezone error](https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/master/docs/faq/README.md#zoneinfozip-no-such-file-or-directory-error-when-using-offpeaktimezone).
## Why was this MR needed?
Alpine does not include timezone data files by default and the lack of tz information causes a fatal error.https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/648Include note about volume path on OSX.2017-08-21T15:25:25Zusername-removed-1531612Include note about volume path on OSX.> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
Provide volume path information for people on OSX.
## Why was this MR needed?
T...> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
Provide volume path information for people on OSX.
## Why was this MR needed?
To understand the correct path on OSX, you need to understand path conventions on Linux and choose an analogous path. The instruction removes that requirement on the reader.
## Are there points in the code the reviewer needs to double check?
No code.
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
None.https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/645fix: read error from upload artifacts execution.2017-08-21T07:11:41Zusername-removed-4080fix: read error from upload artifacts execution.## What does this MR do?
Fixes a bug when an error occurs during the "artifacts upload" stage.
## Why was this MR needed?
During a failure in the upload artifacts step of a build jobs were not failing. This is a problem.
I have teste...## What does this MR do?
Fixes a bug when an error occurs during the "artifacts upload" stage.
## Why was this MR needed?
During a failure in the upload artifacts step of a build jobs were not failing. This is a problem.
I have tested my patch with a local build and it makes the job fail if an error occurs during artifact uploading execution:
- Example before patch https://gitlab.com/paulrbr/paulrbr.gitlab.io/-/jobs/28482190 (forcing to always return an error on upload artifact)
```
FATAL: invalid argument
Job succeeded
```
- Example after patch https://gitlab.com/paulrbr/paulrbr.gitlab.io/-/jobs/28483043 (forcing to always return an error on upload artifact)
```
FATAL: invalid argument
ERROR: Job failed: exit code 1
```
## Are there points in the code the reviewer needs to double check?
Help would be appreciated to create a test case for `failed uploads` builds.
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Fixes #25849.5Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.com