gitlab-runner merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests2017-10-04T11:00:59Zhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/708Hide tokens from URLs printed in job's trace2017-10-04T11:00:59ZTomasz Maczukintomasz@gitlab.comHide tokens from URLs printed in job's trace> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
Removes known token patterns from job's output
## Why was this MR needed?
## Ar...> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
Removes known token patterns from job's output
## Why was this MR needed?
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Closes #274110.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/703update git-lfs to 2.3.12017-10-02T12:31:56Zusername-removed-1339859update git-lfs to 2.3.1## What does this MR do?
This MR updates git-lfs binary from `2.1.1` to `2.3.1` in helper docker image
## Why was this MR needed?
Important bug fixes was added to git-lfs since `2.1.1` release.
For example we encountered the followin...## What does this MR do?
This MR updates git-lfs binary from `2.1.1` to `2.3.1` in helper docker image
## Why was this MR needed?
Important bug fixes was added to git-lfs since `2.1.1` release.
For example we encountered the following bugs in git-lfs:
* [Retry on timeout or temporary errors](https://github.com/git-lfs/git-lfs/commit/9cb274ef51802bd9df4410925845acc9f6966042)
* [git-lfs died on signal when clone large repository](https://github.com/git-lfs/git-lfs/issues/2439)
## Are there points in the code the reviewer needs to double check?
Please review [git-lfs changelog](https://github.com/git-lfs/git-lfs/blob/master/CHANGELOG.md)
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/701Fix small typo in Docker Machine part of executors/README.md2017-09-29T13:46:29Zusername-removed-419458Fix small typo in Docker Machine part of executors/README.md## What does this MR do?
Fixing a small typo in Docker Machine part of executors/README.md## What does this MR do?
Fixing a small typo in Docker Machine part of executors/README.mdhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/699Remove deprecation message from service management commands2017-09-27T16:56:20ZTomasz Maczukintomasz@gitlab.comRemove deprecation message from service management commands## What does this MR do?
Removes the deprecation message printed when service management commands are used. The commands are still deprecated, but the message is very annoying and confusing at the moment, so it will be
## Why was this...## What does this MR do?
Removes the deprecation message printed when service management commands are used. The commands are still deprecated, but the message is very annoying and confusing at the moment, so it will be
## Why was this MR needed?
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?10.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/698Construct git remote URL based on configuration2017-10-05T09:18:57ZZeger-Jan van de Wegzegerjan@gitlab.comConstruct git remote URL based on configuration## What does this MR do?
Fixes #1141
## Why was this MR needed?
We might clone while the URL gitlab is exposed as application is not reachable due to firewalls.
## Does this MR meet the acceptance criteria?
- [ ] Documentation creat...## What does this MR do?
Fixes #1141
## Why was this MR needed?
We might clone while the URL gitlab is exposed as application is not reachable due to firewalls.
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)10.1Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/697Directly return result of b.writeSubmoduleUpdateCmds()2017-09-29T13:46:52Zusername-removed-42525Directly return result of b.writeSubmoduleUpdateCmds()## What does this MR do?
Simplify code by removing unnecessary IF statement.## What does this MR do?
Simplify code by removing unnecessary IF statement.https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/696Fix gitlab-runner pattern in .gitignore2017-09-27T08:14:36ZAlessio CaiazzaFix gitlab-runner pattern in .gitignoreThe binary detection pattern in `.gitignore` is broken (at least on git 2.14.1 mac OS)The binary detection pattern in `.gitignore` is broken (at least on git 2.14.1 mac OS)Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/695Update BurntSushi/toml for MIT-license2017-09-27T11:09:05Zusername-removed-487110Update BurntSushi/toml for MIT-license## What does this MR do?
Update BurntSushi/toml to latest revision so we'll get MIT licensed version instead of WTFPL
## Why was this MR needed?
WTFPL has iffy status
## Does this MR meet the acceptance criteria?
- [ ] Documentation...## What does this MR do?
Update BurntSushi/toml to latest revision so we'll get MIT licensed version instead of WTFPL
## Why was this MR needed?
WTFPL has iffy status
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Closes #2785Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/694Fix small typo on GitLab runner docs homepage2017-09-26T13:30:59Zusername-removed-1279867Fix small typo on GitLab runner docs homepage## What does this MR do?
This MR fixes a small typo under the ['Install GitLab Runner' section of the runner docs homepage](https://docs.gitlab.com/runner/#install-gitlab-runner). The word 'Using' should not have been capitalized.## What does this MR do?
This MR fixes a small typo under the ['Install GitLab Runner' section of the runner docs homepage](https://docs.gitlab.com/runner/#install-gitlab-runner). The word 'Using' should not have been capitalized.https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/693fix runners.kubernetes link2017-09-29T13:48:11Zusername-removed-5332fix runners.kubernetes link## What does this MR do?
Fix link## What does this MR do?
Fix linkhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/692Remove disable_verbose from docs2017-09-20T09:24:17Zusername-removed-357684Remove disable_verbose from docs## What does this MR do?
Remove the non existing option `disable_verbose` from documentation.
## Are there points in the code the reviewer needs to double check?
Maybe removal of the option was not intended (I could not find any inf...## What does this MR do?
Remove the non existing option `disable_verbose` from documentation.
## Are there points in the code the reviewer needs to double check?
Maybe removal of the option was not intended (I could not find any information on why it's gone).
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
#1851https://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/691Add info about pre 10.0 releases2017-10-06T11:00:33ZTomasz Maczukintomasz@gitlab.comAdd info about pre 10.0 releases## What does this MR do?
Adds an information how to install GitLab Runner from DEB/RPM repository for versions < 10.0.
References #2764 and #2765## What does this MR do?
Adds an information how to install GitLab Runner from DEB/RPM repository for versions < 10.0.
References #2764 and #276510.0Achilleas PipinellisAchilleas Pipinellishttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/690Expose if running in a disposable environment2017-10-02T09:24:07ZAlessio CaiazzaExpose if running in a disposable environmentExpose if running in a disposable environment.
It can be detected during the build with `CI_DISPOSABLE` env and programmatically with `common.Build.Disposable`
## What are the relevant issue numbers?
#2148 !687Expose if running in a disposable environment.
It can be detected during the build with `CI_DISPOSABLE` env and programmatically with `common.Build.Disposable`
## What are the relevant issue numbers?
#2148 !687Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/689Collect metrics on build stages2017-10-02T14:46:50ZAlessio CaiazzaCollect metrics on build stages## What does this MR do?
Wrap each stage executions with a timestamped section identifier.
Sample output here: https://gitlab.com/nolith/ci-tests/-/jobs/33067371
## Why was this MR needed?
See #2505 and https://gitlab.com/gitlab-org/...## What does this MR do?
Wrap each stage executions with a timestamped section identifier.
Sample output here: https://gitlab.com/nolith/ci-tests/-/jobs/33067371
## Why was this MR needed?
See #2505 and https://gitlab.com/gitlab-org/gitlab-ce/issues/37970
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Closes #250510.1Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/688Allow customising go test flags with TESTFLAGS variable2017-09-18T11:31:07ZAlessio CaiazzaAllow customising go test flags with TESTFLAGS variableThis MR allows customising `go test` flags while using `make test`.
For instance `TESTFLAGS="-short -v" make test` will skip coverage and integration tests while running with verbose flag.This MR allows customising `go test` flags while using `make test`.
For instance `TESTFLAGS="-short -v" make test` will skip coverage and integration tests while running with verbose flag.Tomasz Maczukintomasz@gitlab.comTomasz Maczukintomasz@gitlab.comhttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/687Set git SSL information only for gitlab host2017-10-06T07:40:41ZAlessio CaiazzaSet git SSL information only for gitlab host## What does this MR do?
This MR overrides git SSL config only for the gitlab host
## Why was this MR needed?
See #2148
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteri...## What does this MR do?
This MR overrides git SSL config only for the gitlab host
## Why was this MR needed?
See #2148
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Closes #2148Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/686Make registration to lock Runner to project real2017-09-19T14:53:46ZTomasz Maczukintomasz@gitlab.comMake registration to lock Runner to project real> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
Improves change added with !657.
## Why was this MR needed?
With !657 we've pre...> This is a general Merge Request template. Consider to choose a template
> from the list above if it will match your case more.
## What does this MR do?
Improves change added with !657.
## Why was this MR needed?
With !657 we've pretended to make `locked=true` a default option of Runner's registration process. At this moment Runner should be - by default - locked to the Project if it was not explicitly specified. However, the MR haven't introduce the most important change :).
This MR adds that change.
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
References #261510.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/684Fix randomly failing test from commands/single_test.go2017-09-14T13:52:05ZTomasz Maczukintomasz@gitlab.comFix randomly failing test from commands/single_test.go## What does this MR do?
Fixes randomly failing tests from `commands/single_test.go` in a way proposed at https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/683#note_40207766. Replacement for !683.
## Why was this MR needed...## What does this MR do?
Fixes randomly failing tests from `commands/single_test.go` in a way proposed at https://gitlab.com/gitlab-org/gitlab-runner/merge_requests/683#note_40207766. Replacement for !683.
## Why was this MR needed?
Please look into !683 for a reference.
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- [ ] Documentation created/updated
- Tests
- [ ] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?10.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/681Mark docker-ssh and docker-ssh+machine executors as deprecated2017-09-14T13:53:11ZTomasz Maczukintomasz@gitlab.comMark docker-ssh and docker-ssh+machine executors as deprecated## What does this MR do?
Adds deprecation notices for `docker-ssh` and `docker-ssh+machine` executors.
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [-] Added for this feature/bug
- [ ...## What does this MR do?
Adds deprecation notices for `docker-ssh` and `docker-ssh+machine` executors.
## Does this MR meet the acceptance criteria?
- [x] Documentation created/updated
- Tests
- [-] Added for this feature/bug
- [ ] All builds are passing
- [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
## What are the relevant issue numbers?
Closes #273210.0Kamil TrzcińśkiKamil Trzcińśkihttps://staging.gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/680Fix tmpfs docker config2017-09-14T18:42:55Zusername-removed-4080Fix tmpfs docker config## What does this MR do?
Fixes the issue #2701
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds are passing
- [x] Tested with a ...## What does this MR do?
Fixes the issue #2701
## Are there points in the code the reviewer needs to double check?
## Does this MR meet the acceptance criteria?
- Tests
- [x] All builds are passing
- [x] Tested with a local build and worked as expected on `services_tmpfs` configuration
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)