Skip to content

Resolve "Show Size of Artifacts and Cache"

Nick Thomas requested to merge nick.thomas/gitlab-ci-multi-runner:1320-upload-progress-bar into master

What does this MR do?

Outputs upload progress for cache and artifacts to the build log

Are there points in the code the reviewer needs to double check?

The progress bar updates as data is read from the source, rather than written to the destination, so its accuracy depends on the size of the read buffer. This could probably be improved with a custom HTTP transport for the client library to use, but it's a lot of work for little gain.

Is the helper appropriate and in the right place?

Why was this MR needed?

Sensible suggestion by a user.

What are the relevant issue numbers?

Closes #1320 . Also see !255 for a less ambitious solution.

Screenshots (if relevant)

Creating cache build/master...
./cache: found 1 matching files                    
Uploading cache.zip                                

cache.zip 0 B / 40.01 MB [---------------------------------------------]   0.00%
cache.zip 40.01 MB / 40.01 MB [======================================] 100.00% 0
cache.zip 40.01 MB / 40.01 MB [====================================] 100.00% 4s
Uploading artifacts...
./artifact: found 1 matching files                 

artifacts.zip 0 B / ? [-------------------------------------------------------=]
artifacts.zip 13.73 MB / ? [--------------------------------=-----------------] 
artifacts.zip 25.36 MB / ? [--------------------=-----------------------------] 
artifacts.zip 34.39 MB / ? [----------------------=---------------------------] 
artifacts.zip 40.01 MB / 40.01 MB [=========================================] 3s
Uploading artifacts to coordinator... ok            id=635 responseStatus=201 Created token=Sasexv-d
Build succeeded

Merge request reports