Resolve "Show Size of Artifacts and Cache"

What does this MR do?

Outputs upload progress for cache and artifacts to the build log

Are there points in the code the reviewer needs to double check?

The progress bar updates as data is read from the source, rather than written to the destination, so its accuracy depends on the size of the read buffer. This could probably be improved with a custom HTTP transport for the client library to use, but it's a lot of work for little gain.

Is the helper appropriate and in the right place?

Why was this MR needed?

Sensible suggestion by a user.

What are the relevant issue numbers?

Closes #1320 . Also see !255 for a less ambitious solution.

Screenshots (if relevant)

Creating cache build/master...
./cache: found 1 matching files                    
Uploading cache.zip                                

cache.zip 0 B / 40.01 MB [---------------------------------------------]   0.00%
cache.zip 40.01 MB / 40.01 MB [======================================] 100.00% 0
cache.zip 40.01 MB / 40.01 MB [====================================] 100.00% 4s
Uploading artifacts...
./artifact: found 1 matching files                 

artifacts.zip 0 B / ? [-------------------------------------------------------=]
artifacts.zip 13.73 MB / ? [--------------------------------=-----------------] 
artifacts.zip 25.36 MB / ? [--------------------=-----------------------------] 
artifacts.zip 34.39 MB / ? [----------------------=---------------------------] 
artifacts.zip 40.01 MB / 40.01 MB [=========================================] 3s
Uploading artifacts to coordinator... ok            id=635 responseStatus=201 Created token=Sasexv-d
Build succeeded

Reassigned to @ayufan

Looks nice @nick.thomas :)

Added 2 commits:

• dbbdc20a - Address review comments for progress bar in CacheArchiverCommand
• e003566d - Finish outputting the progress bar before signalling upload completion in ArtifactsUploaderCommand

@ayufan hopefully that's better :)

Milestone changed to %v1.5

mentioned in merge request !255

Resolved all discussions

Just sorting out that merge conflict

Added 62 commits:

• e003566d...0e707a58 - 60 commits from branch gitlab-org:master
• 6b085753 - Merge conflicts
• a8c13de5 - Re-vendor pb

Added 6 commits:

• a8c13de5...2e36ec6c - 5 commits from branch gitlab-org:master
• 942efde0 - Merge branch 'master' of https://gitlab.com/gitlab-org/gitlab-ci-multi-runner in…

Added 84 commits:

• 942efde0...a5eec436 - 83 commits from branch gitlab-org:master
• 480e02f8 - Branch merge

Milestone changed to %Backlog

@nick.thomas What is the status of this MR?

@tmaczukin @ayufan wants it to go in after gitlab-ce has proper terminal emulation support

@tmaczukin this is finished :)

OK, understood :)

Added improvement label

mentioned in issue #2316 (closed)

@nick.thomas Ping! :)

@ayufan @rymai I can fix this up if we're going to merge it immediately. The last I heard was that it was to wait until GitLab got proper ANSI terminal support... which hasn't happened yet. Let me know.

@nick.thomas Ok, too bad!

While a progress bar might be nice eye candy for the few times someone actually watches a live stream of the commands rushing by, the actual main functionality I'm interested in is the reporting of the artifact/cache size. At elast the functionality from !255 should be implemented asap, while this one might still need to wait until terminal support lands eventually.

@markusteufelberger I agree, if ANSI terminal support is coming soon, we could at least already display the artifacts/cache size?

Yeah, unfortunatelly we don't really know when ANSI terminal is going to be merged :( So doing simple change: How long it takes to download/upload cache and it's size is easy win.

removed assignee

"Accepting Merge Requests"... but this IS a merge request! And there is a different one (!255) which implements the simple version of this?

What is the current status of this? Waiting for ANSI support, waiting for someone to resolve merge conflicts and merge as-is or waiting someone to rewrite this in a more limited implementation?

added Accepting Merge Requests label

closed