WIP: Replace github.com/fsouza/go-dockerclient with github.com/docker/engine-api

Helper methods that have changed considerably with the switch:

• ContainerAttach
• ContainerLogs
• ImageImport
• ImagePull

I'm not sure about the authentication for ImagePull, in particular.

The docker configuration reading code in go-dockerclient was inlined into helpers/docker/auth_config.go. Would love suggestions on how to get away from that.

Two sites in executor_docker.go now construct fake types.Container members with incomplete information (just ID and Name specified). Changing the slices that these are stored in to only hold the id might clean this up. engine-api/client.ContainerInspect returns types.ContainerJSON instead of types.Container, and there isn't a trivial way to convert between the two AFAICT.

Several 'streaming' sites (ContainerLogs, ImageImport) have had consumers open-coded into them, and I'm not sure these are sensible.

Other than that, it's clearly awesome. Thoughts, @ayufan, @tmaczukin?

Closes #1606 (closed)

Added 8 commits:

• 9b807170...6482befb - 6 commits from branch gitlab-org:master
• 364934df - Merge branch 'master' into 1606-use-engine-api
• 954fbdca - Branch merge

Added 1 commit:

• d9e1befc - Reduce the cyclomatic complexity of addCacheVolume, in a roundabout way

Added 1 commit:

• 364968d4 - Reduce the cyclomatic complexity of addCacheVolume, in a roundabout way

I think #1584 (closed) will still occur with this change, since you're attaching after starting the container.

Probably, this is at the stage of being (as far as possible) a straight 1:1 conversion at the moment.

That's definitely a bug worth fixing though, I'll see if we can get to it.

Added 78 commits:

• 364968d4...a5eec436 - 77 commits from branch gitlab-org:master
• e4f1553c - Merge with master

I would really love us to move away from issuing raw docker commands and instead using docker-compose if it's stable enough: https://github.com/docker/libcompose.

But this is much, much bigger task. But it will basically reduce complexity of executor_docker.go to be a set of created docker-compose.yml.

Added 1 commit:

• b0829489 - Fix up Godeps

Added 5 commits:

• b0829489...a3d5829a - 4 commits from branch gitlab-org:master
• 797c6d64 - Resolve merge conflict with 'defer Cleanup()'

Added 11 commits:

• 797c6d64...57e93608 - 10 commits from branch gitlab-org:master
• 5b00b414 - Resolve merge conflict

Added 1 commit:

• 4228aea1 - Reorder imports in the docker-ssh executor

@bkc notes that engine-api/client is already deprecated in favour of github.com/docker/docker/client

fml, etc.

I'm going to start on that in a second branch.

@nick.thomas Should we close this MR in such case?

mentioned in issue #1222 (closed)

@tmaczukin yep, happy with that. Closing in favour of !301 (merged)

This isn't half turning out to be an adventure!

Status changed to closed