Skip to content

Exclude unused options from AbstractExecutor.Build.Options

Tomasz Maczukin requested to merge improvement/remove-annoying-warning-about-environment-option into master

What does this MR do?

Adds a mechanism to exclude unused keys from options map sent with build response.

Why was this MR needed?

Some options, for example environment are serialized by GitLab to the options map, but are not used by Runner at all. And since Runner is verifying received options against options supported by used executor and shell this ends with an annoying warning like described in #1706 (closed).

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #1706 (closed)

Merge request reports