Skip to content

Extended verify command with runner selector

Alessio Caiazza requested to merge nolith/gitlab-runner:verify_selector into master

What does this MR do?

This MR implements runner selectors in verify command.

In case of errors it will terminate with non-zero exit code.

Why was this MR needed?

This improvement has been scheduled for %v9.1 milestone with #2171 (closed) and #2073 (closed)

Are there points in the code the reviewer needs to double check?

I tried to stick with the principle of least surprise regarding non-zero exit code strategy.

  • If any of the verified runners failed the check, it returns non-zero unless you asked to delete
  • If a filtering parameter is issued and it didn't match any runner, non-zero is returned
    • this has the side effect that asking to verify an empty configuration will always return non-zero

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #2073 (closed) Closes #2171 (closed)

Merge request reports