Skip to content

Improve docker machine removal

Kamil Trzcińśki requested to merge improve-docker-machine-remove into master

This is a general Merge Request template. Consider to choose a template from the list above if it will match your case more.

What does this MR do?

Improves docker machine removal

Retry each machine removal to up 3 times. After that allow performing one removal of all stuck machines (machine is tried to be removed more than 3 times), at most one machine per retry interval which is 30s.

This allows to greatly limit an amount of API failures when using docker+machine.

Why was this MR needed?

Are there points in the code the reviewer needs to double check?

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/2098

Merge request reports