Skip to content

Resolve "GitLab Runner http endpoint should default to 9252"

username-removed-742162 requested to merge Rukenshia/gitlab-ci-multi-runner:2454-metrics-server-default-port into master

This is a general Merge Request template. Consider to choose a template from the list above if it will match your case more.

What does this MR do?

Defaults the MetricsServer Port to 9252 as discussed in #2454 (closed).

Why was this MR needed?

#2454 (closed)

Are there points in the code the reviewer needs to double check?

I don't really like the way I had to handle the error of net.SplitHostPort, maybe you have a better idea on how to do that. The only alternative i can think of is maybe using url.Parse instead.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #2454 (closed)

Edited by username-removed-742162

Merge request reports