Update cli dep

What does this MR do?

Update the dependency, it was moved to another namespace. This make getting a newer version easier too.

Are there points in the code the reviewer needs to double check?

That it still works as expected

Does this MR meet the acceptance criteria?

• Documentation created/updated
• Tests
  • [-] Added for this feature/bug
  • All builds are passing

What are the relevant issue numbers?

Might help with https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/issues/1904, but needs to be done anyway

One comment, otherwise LGTM

assigned to @nick.thomas

resolved all discussions

LGTM

@zj do you know if it resolves the panic mentioned in #1904 ?

assigned to @tmaczukin

@nick.thomas I'm certain it won't fix it, but wanted to upgrade the path for the import first

Yep, it doesn't fix the problem mentioned in #1904 - Runner still panics. But having a new dependency we can try to upgrade it to newer version. I've recently used last tagged version (1.19.1). It was tagged 9 months ago, but the problem of panic was already resolved there :)

As for this MR - one little comment, but I see that @nick.thomas already mentioned that old dependency was not removed from vendor/vendor.json. Other than that it looks good. Binary is still working so I think we can safely merge it.

However, let's merge this after releasing %9.5 - it will go with %10.0 and in this version we can also try to upgrade the library :)

assigned to @zj

resolved all discussions

@tmaczukin Can you MWPS this too?

approved this merge request

@zj Done!

canceled the automatic merge

@zj I see you've also updated the library. I've disabled the MWPS to check first how it behaves with newer version. Also I see you've updated the library to current master revision while we're trying to use tagged versions whenever it's possible. There is a 1.20.0 version of github.com/urfave/cli tagged 12 days ago and there is no important changes after that (only a fix in documentation that is not important in our case). Please switch the library to 1.20.0 and push again, and I'll do some manual tests meanwhile :)

OK, 1.20.0 seems also to work properly. However - it doesn't resolve #1904.

@zj Please update the MR so it will install 1.20.0 instead of current master of the library and I can push MWPS :)

Done. Only a README change, but now we're on a tag.

assigned to @tmaczukin

approved this merge request

changed milestone to %10.0

merged