Skip to content
Snippets Groups Projects

Mark docker-ssh and docker-ssh+machine executors as deprecated

Merged Tomasz Maczukin requested to merge deprecate-docker-ssh-executor into master
All threads resolved!

What does this MR do?

Adds deprecation notices for docker-ssh and docker-ssh+machine executors.

Does this MR meet the acceptance criteria?

  • Documentation created/updated
  • Tests
    • [-] Added for this feature/bug
    • All builds are passing
  • Branch has no merge conflicts with master (if you do - rebase it please)

What are the relevant issue numbers?

Closes #2732 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @axil Can you review?

  • Tomasz Maczukin resolved all discussions

    resolved all discussions

  • @ayufan looks good! @tmaczukin one minor thing, you replaced 'Note' with 'Notice', although we use 'Note' everywhere else in the documentation, can you change it back?

  • Author Maintainer

    OK, it seems that we use both Notice and Note in Runner's documentation. I thought we're using Notice only, but now I see that Note is used more times. I can change it back, and change this also in the second MR and rest will be updated in the future.

  • Author Maintainer

    @axil Done!

  • LGTM! You have my blessing :thumbsup:

  • Kamil Trzcińśki approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading