Skip to content
Snippets Groups Projects
Select Git revision
  • super-important-update
  • foo-1516892483401
  • foo
  • foo-1516892233675
  • patch-3
  • patch-2
  • jramsay-ide-testing
  • next
  • master default protected
  • go-wrappers
  • make-it-2017
  • 3-6-stable
  • gitaly-post-receive
  • http-excon
  • redis-full-gem
  • feature/gitaly-feature-flag
  • patch-1
  • fix_hook_env
  • memory-limit
  • update-redis-rb-3.3.1
  • v5.0.4
  • v5.0.3
  • v5.0.2
  • v5.0.0
  • v3.6.7
  • v4.1.1
  • v4.1.0
  • v4.0.3
  • v4.0.2
  • v4.0.1
  • v4.0.0
  • v3.6.6
  • v3.6.5
  • v3.6.4
  • v3.6.3
  • v3.6.2
  • v3.6.1
  • v3.6.0
  • v3.5.0
  • v3.4.0
40 results

gitlab_access.rb

  • Stan Hu's avatar
    7a70b6d6
    Remove extraneous newlines in pre-receive hook · 7a70b6d6
    Stan Hu authored 
    Found while investigating slow performance in gitlab-org/gitlab-ce#17225

We were adding a newline for every branch push because:

1. GitlabAccess calls changes.lines, which keeps the newline (e.g. ['00000000 12345678 refs/heads/master\n'])
2. GitlabNet calls changes.join("\n"), which adds another newline
    7a70b6d6
    History
    Remove extraneous newlines in pre-receive hook
    Stan Hu authored 
    Found while investigating slow performance in gitlab-org/gitlab-ce#17225

We were adding a newline for every branch push because:

1. GitlabAccess calls changes.lines, which keeps the newline (e.g. ['00000000 12345678 refs/heads/master\n'])
2. GitlabNet calls changes.join("\n"), which adds another newline
Code owners
Assign users and groups as approvers for specific file changes. Learn more.