Skip to content
Snippets Groups Projects
  1. May 09, 2016
    • Stan Hu's avatar
      Remove extraneous newlines in pre-receive hook · 7a70b6d6
      Stan Hu authored
      Found while investigating slow performance in gitlab-org/gitlab-ce#17225
      
      We were adding a newline for every branch push because:
      
      1. GitlabAccess calls changes.lines, which keeps the newline (e.g. ['00000000 12345678 refs/heads/master\n'])
      2. GitlabNet calls changes.join("\n"), which adds another newline
      7a70b6d6
  2. Apr 28, 2016
  3. Apr 25, 2016
  4. Apr 20, 2016
    • Stan Hu's avatar
      Merge branch 'aiionx/gitlab-shell-aiionx-post_receive_jid' into 'master' · c73b6a1c
      Stan Hu authored
      Update post receive worker so it logs a unique JID in sidekiq
      
      Taken from !50.
      
      Instead of
      
      ```
      2016-04-14T03:07:32.373Z 5285 TID-osycgmlyo PostReceive JID- INFO: start
      2016-04-14T03:07:32.374Z 5285 TID-osycgmlyo PostReceive JID- INFO: arguments: [...]
      2016-04-14T03:07:32.534Z 5285 TID-osycgmlyo PostReceive JID- INFO: done: 0.161 sec
      ```
      
      Have this log
      
      ```
      2016-04-14T03:07:32.373Z 5285 TID-osycgmlyo PostReceive JID-54b0b2f6616cae37e3e87f8a INFO: start
      2016-04-14T03:07:32.374Z 5285 TID-osycgmlyo PostReceive JID-54b0b2f6616cae37e3e87f8a INFO: arguments: [...]
      2016-04-14T03:07:32.534Z 5285 TID-osycgmlyo PostReceive JID-54b0b2f6616cae37e3e87f8a INFO: done: 0.161 sec
      ```
      
      
      This way sidekiq can Log a unique JID in the sidekiq.log for PostReceive.
      So when parsing the logs (with logstash for example) you know it belongs to that unique job.
      
      This puts the logs in a uniform manner like the other workers that are pushed to redis (which do have a JID)
      For example the ProjectWebHookWorker
      
      ```
      2016-04-14T03:13:07.917Z 5285 TID-osycsh7z0 ProjectWebHookWorker JID-800085fb3cf7241fdeecc6ec INFO: start
      2016-04-14T03:13:07.918Z 5285 TID-osycsh7z0 ProjectWebHookWorker JID-800085fb3cf7241fdeecc6ec INFO: arguments: [...]
      2016-04-14T03:13:12.500Z 5285 TID-osycsh7z0 ProjectWebHookWorker JID-800085fb3cf7241fdeecc6ec INFO: done: 4.583 sec
      ```
      
      
      See merge request !55
      c73b6a1c
    • aiionx's avatar
  5. Apr 19, 2016
  6. Apr 18, 2016
  7. Apr 16, 2016
  8. Apr 07, 2016
  9. Apr 06, 2016
  10. Mar 31, 2016
  11. Mar 29, 2016
  12. Mar 24, 2016
  13. Mar 21, 2016
  14. Mar 18, 2016
  15. Mar 16, 2016
Loading