Go programs are not go1.5-compatible

In !127 (merged) we added a hello-world go binary. Unfortunately, this fails to compile on Go 1.5:

root@025f6642d625:/gitlab-shell# bin/compile 
# gitlab.com/gitlab-org/gitlab-shell/go/vendor/google.golang.org/grpc/transport
go_build/src/gitlab.com/gitlab-org/gitlab-shell/go/vendor/google.golang.org/grpc/transport/http2_client.go:133: undefined: dialContext
command failed: {"GOPATH"=>"/gitlab-shell/go_build", "GO15VENDOREXPERIMENT"=>"1"} go install gitlab.com/gitlab-org/gitlab-shell/go/cmd/...
root@025f6642d625:/gitlab-shell#

The README.md states that go1.5 is supported, and some install-from-source users are having trouble as a result, e.g.: https://about.gitlab.com/2017/05/22/gitlab-9-2-released/#comment-3320082300

Can we make this hello-world program go1.5-compatible in a hurry? Or is the better route to update the README and the install-from-source instructions? Is grpc fundamentally incompatible with go1.5 or is it just missing some files due to being vendored under the wrong version of go?

Relatedly, I was hoping to add .gitlab-ci.yml compile:go1.{5,6,7,8} tasks but the bin/compile script is currently written in Ruby, making this more difficult than necessary (we can't just use the golang:1.X docker images). One way or another, we should be compiling, and running unit tests when they start to be needed, for every version of Go that we support.

/cc @bkc @jacobvosmaer-gitlab

changed the description

same here got this too

[git@dev gitlab-shell]$ go version
go version go1.5.3 linux/amd64

how to solve this problem?

I install v1.8.3 is solve ...

Hi, Same error

# sudo -u git -H git checkout v$(</home/git/gitlab/GITLAB_SHELL_VERSION)
HEAD is now at 285c061... Bump version to 5.0.4
root@gitlab:/home/git/gitlab-shell# sudo -u git -H bin/compile
# gitlab.com/gitlab-org/gitlab-shell/go/vendor/google.golang.org/grpc/transport
go_build/src/gitlab.com/gitlab-org/gitlab-shell/go/vendor/google.golang.org/grpc/transport/http2_client.go:133: undefined: dialContext
command failed: {"GOPATH"=>"/home/git/gitlab-shell/go_build", "GO15VENDOREXPERIMENT"=>"1"} go install gitlab.com/gitlab-org/gitlab-shell/go/cmd/...

System information
System:		Ubuntu 14.04
Current User:	git
Using RVM:	no
Ruby Version:	2.3.1p112
Gem Version:	2.5.1
Bundler Version:1.14.5
Rake Version:	10.5.0
Redis Version:	2.8.4
Git Version:	2.10.2
Sidekiq Version:5.0.0

GitLab information
Version:	9.2.2
Revision:	cbde95c
Directory:	/home/git/gitlab
DB Adapter:	mysql2

@nick.thomas This one says "update docs to state go 1.8" https://gitlab.com/gitlab-org/gitlab-ce/issues/31943

As for the CI you could use this image: https://gitlab.com/gitlab-org/gitlab-build-images/blob/master/Dockerfile.ruby-2.4.1-golang-1.8-git-2.7-phantomjs-2.1-node-7.1-postgresql-9.6 (or make a new one with only ruby+golang)

This should be an easy fix, we just need to grab an older version of grpc which is not going to be a problem.

mentioned in merge request !133 (merged)

assigned to @jacobvosmaer-gitlab

@nick.thomas good idea to add a matrix for multiple go versions. I am not a big fan of shell scripts however.

We don't need a special version of Ruby for bin/compile. Can't we apt-get install ruby from within the go images?

working on that in https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/134

@jacobvosmaer-gitlab we can do that, but it will increase build time a little.The base image probably has perl... ;)

closed via commit 1472f046