gitlab-shell merge requestshttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests2022-10-04T12:05:25Zhttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/174Super critical update to readme2022-10-04T12:05:25ZRobert MaySuper critical update to readmeCloses #111Closes #111Robert MayRobert Mayhttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/173test2018-06-04T16:00:07ZJan Provazniktesthttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/171Add GL_REPO_PATH envvar to check access request2018-01-09T22:51:43Zusername-removed-506061Add GL_REPO_PATH envvar to check access requestReference: https://gitlab.com/gitlab-org/gitaly/issues/629Reference: https://gitlab.com/gitlab-org/gitaly/issues/629username-removed-506061username-removed-506061https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/166WIP: Handle push options2017-09-22T02:21:58Zusername-removed-90962WIP: Handle push optionsThis MR enables the `pre_receive` and `post_receive` hooks to handle the newly-introduced Git *push options*.
The immediate goal is to enable `git push -o skip-ci ...` functionality. This implementation however, is not tied to `skip-c...This MR enables the `pre_receive` and `post_receive` hooks to handle the newly-introduced Git *push options*.
The immediate goal is to enable `git push -o skip-ci ...` functionality. This implementation however, is not tied to `skip-ci` and pushes all of the push options to GitLab to handle.
`gitlab-shell` is in the middle of moving from using Redis to an internal API for handling the post-receive hook (see #77). This implementation only passes the push options using the new internal API.
See gitlab-org/gitlab-ce#18667https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/165Update gitlab_keys: list-keys failed to output anything2017-08-31T21:24:01Zusername-removed-1083216Update gitlab_keys: list-keys failed to output anythinghttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/121Update LICENSE year to 20172017-02-09T08:45:35Zusername-removed-14714Update LICENSE year to 2017https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/108More error verbosity when the API check fails2016-11-25T19:22:17Zusername-removed-204741More error verbosity when the API check failsThe error message displayed when the check utility runs is not useful.
I agree that error details can be found in the *gitlab-shell* logs but:
- When such check utility fails I expect to have details of the error in-hand without ha...The error message displayed when the check utility runs is not useful.
I agree that error details can be found in the *gitlab-shell* logs but:
- When such check utility fails I expect to have details of the error in-hand without having to search where could be logged the underlying error and praise if this one is indeed logged somewhere.
- More verbosity helps to take the right action and avoid misleading message (here the irrelevant "*Try fixing it:*" for my use case):
![image](/uploads/e9cae154f2e9f45499d2c1ee788db4da/image.png)
My use case:
I compiled Ruby against a specific OpenSSL version but forgot to provide CA Root Certificates to this OpenSSL setup. Consequence is that all HTTPS URLS (including the gitlab api url) have certs that can't be validated (by ruby code, not from the system), so a check failure. The current message is just useless to help me understand the issue.
The MR adds the behind-the-scene message (the one that is logged) in the output, which is way more useful in understanding the issue:
![image](/uploads/83fb294ecfaabf67acd7d92f0a7afb40/image.png)https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/105update makefile: phony is target not variable2016-11-16T00:21:42Zusername-removed-163557update makefile: phony is target not variable`.PHONY` is make target not variable
https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
also cleanup unused `PWD` variable, if such behaviour is wanted `$(CURDIR)` builtin is better used`.PHONY` is make target not variable
https://www.gnu.org/software/make/manual/html_node/Phony-Targets.html
also cleanup unused `PWD` variable, if such behaviour is wanted `$(CURDIR)` builtin is better usedhttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/88add support for custom configuration of server side bare repos2017-02-17T18:39:05Zusername-removed-698206add support for custom configuration of server side bare reposconfigure bare repos by specifying options in gitlab-shell config.yml
this MR closes #60configure bare repos by specifying options in gitlab-shell config.yml
this MR closes #60https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/80Add Merge Request url on post-receive hook2016-09-23T21:50:45Zusername-removed-374204Add Merge Request url on post-receive hookThis change adds the option to print the merge request URL on terminal output after the user pushes into a branch. Like bitbucket does.
I don't know if this is a feature that gitlab wants, but if so and this needs to be changed, feel ...This change adds the option to print the merge request URL on terminal output after the user pushes into a branch. Like bitbucket does.
I don't know if this is a feature that gitlab wants, but if so and this needs to be changed, feel free to tell me. Thanks :beers:
![28989d72-c221-11e5-90ae-4b4028e5ba85](/uploads/ff20bd829d2e8e3c642a8448f0724380/28989d72-c221-11e5-90ae-4b4028e5ba85.png)https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/76Revert commit "Unset GL_ID and GL_PROTOCOL immediately"2016-07-28T00:12:36Zusername-removed-639709Revert commit "Unset GL_ID and GL_PROTOCOL immediately"Those variables are very useful with custom_hooks scripts.Those variables are very useful with custom_hooks scripts.https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/58Remove extraneous newlines in pre-receive hook2016-05-09T01:24:26ZStan HuRemove extraneous newlines in pre-receive hookFound while investigating slow performance in gitlab-org/gitlab-ce#17225
We were adding a newline for every branch push because:
1. GitlabAccess calls changes.lines, which keeps the newline (e.g. ['00000000 12345678 refs/heads/mast...Found while investigating slow performance in gitlab-org/gitlab-ce#17225
We were adding a newline for every branch push because:
1. GitlabAccess calls changes.lines, which keeps the newline (e.g. ['00000000 12345678 refs/heads/master\n'])
2. GitlabNet calls changes.join("\n"), which adds another newlinehttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/40There is no need to keep old hooks around - remove them2016-04-27T15:35:49Zusername-removed-300241kirr@nexedi.comThere is no need to keep old hooks around - remove themgitlab-shell uses completely own whole set of git hooks and just
symlinks `repo.git/hooks` to `path/to/gitlab-shell/hooks/`.
Original hooks that git added there - when initializing repository -
from its template, and which are by de...gitlab-shell uses completely own whole set of git hooks and just
symlinks `repo.git/hooks` to `path/to/gitlab-shell/hooks/`.
Original hooks that git added there - when initializing repository -
from its template, and which are by default deactivated, are currently
moved to `repo.git/hooks.old.<timestamp>`, e.g.
```
$ ls -F nexedi/helloweb.git/
config
description
HEAD
hooks@ --> ...path/to/gitlab-shell/hooks/
hooks.old.1446564288/
info/
packed-refs
refs/
$ ls -F nexedi/helloweb.git/hooks.old.1446564288/
applypatch-msg.sample*
post-update.sample*
pre-commit.sample*
pre-push.sample*
update.sample*
commit-msg.sample*
pre-applypatch.sample*
prepare-commit-msg.sample*
pre-rebase.sample*
```
On the other hand, `hooks.old.<timestamp>` are not used anywhere and are
left there "just in case". But what is the point to keep those pristine
samples git creates by default? And we are sure those files are always
results of gitlab-shell initializing a repository, as it is
gitlab-shell's job to create/remove/update/etc repositories.
So do not keep old hooks, remove them.
P.S. The patch that introduced whole-hooks-dir-symlinking is
db81327b (Symlink the whole hooks directory).
/cc @dzaporozhets, @jacobvosmaerhttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/31update paths2015-11-13T11:11:24Zusername-removed-3855update pathsfor !28for !28https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/26WIP: Remove create_tag functionality for cleanup2016-12-05T14:27:55Zusername-removed-274314WIP: Remove create_tag functionality for cleanupFollowing https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1757, somehow I missed creating a merge request for this branch, sorry.
cc @DouweM
**@rymai: I put this MR in WIP since the GitLab MR has not been merged yet.**Following https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1757, somehow I missed creating a merge request for this branch, sorry.
cc @DouweM
**@rymai: I put this MR in WIP since the GitLab MR has not been merged yet.**https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/24Drop create branch support as a shell command for cleanup2015-11-03T22:46:55Zusername-removed-274314Drop create branch support as a shell command for cleanupThis is a cleanup task to remove the `create-branch` command out of the shell as it is supported by gitlab_git now with better performance.
Rspec tests were executed to validate the change.
cc @DouweM This is a cleanup task to remove the `create-branch` command out of the shell as it is supported by gitlab_git now with better performance.
Rspec tests were executed to validate the change.
cc @DouweM https://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/7Add git-fat support2015-04-13T08:35:53Zusername-removed-6432Add git-fat supportThis adds git-fat support to gitlab-shell.
git-fat access is handled with the `rsync` command which can be used over SSH similar to how Git operates. git-fat support must be configured per-project via the `add-fat`/`rm-fat` commands ...This adds git-fat support to gitlab-shell.
git-fat access is handled with the `rsync` command which can be used over SSH similar to how Git operates. git-fat support must be configured per-project via the `add-fat`/`rm-fat` commands via GitLab.
Shell support is updated for `rsync` support:
* detect `rsync` command
* determine read or write access via `--sender` argument
* extract target directory as: namespace/repo_name
* check remaining arguments for safety
Updated project management commands:
* add-fat: creates a namespace/project.fat directory for large files
* rm-fat: deletes the .fat directory
* mv-project: additionally moves the .fat directory
* fork-project: additionally copies the .fat directoryhttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/3Rescue scawy messages2015-04-09T10:25:22Zusername-removed-32092Rescue scawy messagesSee f9d2e2559 for more detailsSee f9d2e2559 for more detailshttps://staging.gitlab.com/gitlab-org/gitlab-shell/-/merge_requests/1Add Local Update Hook2015-04-13T13:53:26Zusername-removed-15310Add Local Update HookRebased version of add_local_update_hook branch
https://github.com/gitlabhq/gitlab-shell/pull/85
Conficts: gitlab_projects.rb big changes in create_hooks Rebased version of add_local_update_hook branch
https://github.com/gitlabhq/gitlab-shell/pull/85
Conficts: gitlab_projects.rb big changes in create_hooks