Chained global hooks (!111) · Merge requests · GitLab.org / gitlab-shell

An error occurred while fetching this tab.

Merged username-removed-443319 requested to merge glensc/gitlab-shell-pr-245 into master 8 years ago

Dec 01, 2016
- changelog spelling · b77f6530
  Elan Ruusamäe authored 8 years ago
  
  b77f6530
- test expected hook order · d9afbf47
  Elan Ruusamäe authored 8 years ago
  
  d9afbf47
- DRY: add helpers for expect hook calls · f3512031
  Elan Ruusamäe authored 8 years ago
  
  f3512031
- test gl_id_test_hook as global and as repo hook separately · 37148a6c
  Elan Ruusamäe authored 8 years ago
  
  37148a6c
- spec/custom_hook: ensure "before" does complete cleanup · 24d6df6c
  Elan Ruusamäe authored 8 years ago
  
  this fixes problem that tests succeeded locally but failed in ci where parent dirs were missing
  24d6df6c
- spec/custom_hooks: cleanup helpers not to repeat repo path parameter · a0489594
  Elan Ruusamäe authored 8 years ago
  
  a0489594
- fix gl_id_test_hook · 8910d4b0
  Elan Ruusamäe authored 8 years ago
  
  8910d4b0
- cleanup dirs in before to fixup aborted tests · 5043d13b
  Elan Ruusamäe authored 8 years ago
  
  5043d13b
- move helpers to top · 17691041
  Elan Ruusamäe authored 8 years ago
  
  17691041
- changelog entry · 91ba6396
  Elan Ruusamäe authored 8 years ago
  
  91ba6396
- improve wording by using successful instead of ok · 23b90272
  Elan Ruusamäe authored 8 years ago
  
  23b90272
- remove unused create_global_hooks · f8e64aa2
  Elan Ruusamäe authored 8 years ago
  
  f8e64aa2
- avoid Dir.exists? duplication by moving the check to match_hook_files · 872c66e9
  Elan Ruusamäe authored 8 years ago
  
  872c66e9
- use String.end_with? instead of regexp · d87c4b9c
  Elan Ruusamäe authored 8 years ago
  
  d87c4b9c
- remove no longer needed gitlab_init · 5b740fcf
  Elan Ruusamäe authored 8 years ago
  
  5b740fcf
- spec: updated tests to match current code · e60a0ee7
  Elan Ruusamäe authored 8 years ago
  
  e60a0ee7
- custom_hook: chain custom hooks · dbd4bc26
  Elan Ruusamäe authored 8 years ago
  
  update hooks lookup to use <hook>.d/* from repository hooks dir the order would be: 1. <repository>.git/custom_hooks/<hook_name> - per project hook 2. <repository>.git/custom_hooks/<hook_name>.d/* - per project hooks 3. <repository>.git/hooks/<hook_name>.d/* - global hooks only executable files are matched and backup files excluded (*~) and the resulting list is sorted per each lookup
  dbd4bc26
- spec: add tests for global custom hooks · c5cf5439
  Dirk Hörner authored 8 years ago
  
  c5cf5439
- custom_hook: add support for global custom hooks · 0e409ee4
  Dirk Hörner authored 8 years ago
  
  This commit adds the option of having another set of global custom hooks along with the already supported repository local custom hooks. The repository local custom hook is executed first (if available). If successful, execution continues with the global custom hook (if available). This way, local custom hooks get priority over global custom hooks. Global custom hooks can be enabled by placing an executable file into the "custom_hooks" directory within gitlab-shell (create if it does not exist, yet).
  0e409ee4
- custom_hook: refactor to pull repo_path into class · d05522de
  Dirk Hörner authored 8 years ago
  
  This commit takes the GitlabCustomHook a bit clother to the other hook handling classes by receiving the repo_path as argument to initialize() instead of passing it to each method.
  d05522de
- custom_hook: only execute hook if file is executable · 2d774eea
  Dirk Hörner authored 8 years ago
  
  This commit fixes an issue where an existing but unexecutable hook would cause an uncaught execption.
  2d774eea

Admin message

Admin message

Chained global hooks

Merge request reports

Activity