-
- Downloads
There was an error fetching the commit references. Please try again later.
Add and backfill project_id for ci_resources
## What does this MR do and why? Add and backfill project_id for ci_resources. This table has a [desired sharding key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#define-a-desired_sharding_key-to-automatically-backfill-a-sharding_key) configured ([view configuration](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/ci_resources.yml)). This merge request is the first step towards transforming the desired sharding key into a [sharding key](https://docs.gitlab.com/ee/development/database/multiple_databases.html#defining-a-sharding-key-for-all-cell-local-tables). This involves three changes: - Adding a new column that will serve as the sharding key (along with the relevant index and foreign key). - Populating the sharding key when new records are created by adding a database function and trigger. - Scheduling a [batched background migration](https://docs.gitlab.com/ee/development/database/batched_background_migrations.html) to set the sharding key for existing records. Once the background migration has completed, a second merge request will be created to finalize the background migration and validate the not null constraint. ## How to verify We have assigned a random backend engineer from ~"group::pipeline execution" to review these changes. Please review this merge request from a ~backend perspective. The main thing we are looking to verify is that the added column and association match the values specified by the [desired sharding key](https://gitlab.com/gitlab-org/gitlab/-/blob/master/db/docs/ci_resources.yml) configuration and that backfilling the column from this other table makes sense in the context of this feature. When you are finished, please: 1. Trigger the [database testing pipeline](https://docs.gitlab.com/ee/development/database/database_migration_pipeline.html) as instructed by Danger. 1. Request a review from the ~backend maintainer and ~database reviewer suggested by Danger. If you have any questions or concerns, reach out to `@tigerwnz` or @shubhamkrai. This merge request was generated by a once off keep implemented in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/143774 This change was generated by [gitlab-housekeeper](https://gitlab.com/gitlab-org/gitlab/-/tree/master/gems/gitlab-housekeeper) using the Keeps::BackfillDesiredShardingKeySmallTable keep. To provide feedback on your experience with `gitlab-housekeeper` please create an issue with the label ~"GitLab Housekeeper" and consider pinging the author of this keep. Changelog: other
Showing
- db/docs/batched_background_migrations/backfill_ci_resources_project_id.yml 9 additions, 0 deletions...ackground_migrations/backfill_ci_resources_project_id.yml
- db/docs/ci_resources.yml 1 addition, 0 deletionsdb/docs/ci_resources.yml
- db/migrate/20240930154300_add_project_id_to_ci_resources.rb 9 additions, 0 deletionsdb/migrate/20240930154300_add_project_id_to_ci_resources.rb
- db/post_migrate/20240930154301_index_ci_resources_on_project_id.rb 16 additions, 0 deletions...igrate/20240930154301_index_ci_resources_on_project_id.rb
- db/post_migrate/20240930154302_add_ci_resources_project_id_trigger.rb 25 additions, 0 deletions...ate/20240930154302_add_ci_resources_project_id_trigger.rb
- db/post_migrate/20240930154303_queue_backfill_ci_resources_project_id.rb 40 additions, 0 deletions.../20240930154303_queue_backfill_ci_resources_project_id.rb
- db/schema_migrations/20240930154300 1 addition, 0 deletionsdb/schema_migrations/20240930154300
- db/schema_migrations/20240930154301 1 addition, 0 deletionsdb/schema_migrations/20240930154301
- db/schema_migrations/20240930154302 1 addition, 0 deletionsdb/schema_migrations/20240930154302
- db/schema_migrations/20240930154303 1 addition, 0 deletionsdb/schema_migrations/20240930154303
- db/structure.sql 22 additions, 1 deletiondb/structure.sql
- lib/gitlab/background_migration/backfill_ci_resources_project_id.rb 10 additions, 0 deletions.../background_migration/backfill_ci_resources_project_id.rb
- spec/db/schema_spec.rb 1 addition, 0 deletionsspec/db/schema_spec.rb
- spec/lib/gitlab/background_migration/backfill_ci_resources_project_id_spec.rb 16 additions, 0 deletions...ground_migration/backfill_ci_resources_project_id_spec.rb
- spec/migrations/20240930154304_queue_backfill_ci_resources_project_id_spec.rb 33 additions, 0 deletions...0930154304_queue_backfill_ci_resources_project_id_spec.rb
Loading
Please register or sign in to comment