Skip to content
Snippets Groups Projects
Unverified Commit ac9b3ca2 authored by Miranda Fluharty's avatar Miranda Fluharty Committed by GitLab
Browse files

Merge branch 'justin_ho-remove-some-unused-table-classes' into 'master'

Remove unused classes in Audit events and Alert details

See merge request https://gitlab.com/gitlab-org/gitlab/-/merge_requests/169424



Merged-by: default avatarMiranda Fluharty <mfluharty@gitlab.com>
Approved-by: default avatarRajan Mistry <rmistry@gitlab.com>
Approved-by: default avatarMiranda Fluharty <mfluharty@gitlab.com>
Co-authored-by: default avatarJustin Ho Tuan Duong <hduong@gitlab.com>
parents bedf2975 a76f31ca
No related branches found
No related tags found
No related merge requests found
Loading
Loading
@@ -10,9 +10,6 @@ import { isValidURL } from '~/lib/utils/url_utility';
import { s__ } from '~/locale';
import { PAGE_CONFIG } from '~/vue_shared/alert_details/constants';
 
const thClass = '!gl-bg-transparent !gl-border-1 !gl-border-b-solid !gl-border-gray-200';
const tdClass = '!gl-border-gray-100 !gl-p-5';
const allowedFields = [
'iid',
'title',
Loading
Loading
@@ -55,15 +52,12 @@ export default {
{
key: 'fieldName',
label: s__('AlertManagement|Key'),
thClass,
tdClass,
formatter: (string) =>
capitalizeFirstCharacter(convertToSentenceCase(splitCamelCase(string))),
},
{
key: 'value',
thClass: `${thClass} w-60p`,
tdClass,
thClass: 'w-60p',
label: s__('AlertManagement|Value'),
},
],
Loading
Loading
Loading
Loading
@@ -9,8 +9,6 @@ import { LONG_DATE_FORMAT_WITH_TZ } from '~/vue_shared/constants';
import HtmlTableCell from './table_cells/html_table_cell.vue';
import UrlTableCell from './table_cells/url_table_cell.vue';
 
const TABLE_HEADER_CLASSES = 'bg-transparent border-bottom p-3';
export default {
components: {
HtmlTableCell,
Loading
Loading
@@ -57,32 +55,26 @@ export default {
{
key: 'author',
label: s__('AuditLogs|Author'),
thClass: TABLE_HEADER_CLASSES,
},
{
key: 'object',
label: s__('AuditLogs|Object'),
thClass: TABLE_HEADER_CLASSES,
},
{
key: 'action',
label: s__('AuditLogs|Action'),
thClass: TABLE_HEADER_CLASSES,
},
{
key: 'target',
label: s__('AuditLogs|Target'),
thClass: TABLE_HEADER_CLASSES,
},
{
key: 'ip_address',
label: s__('AuditLogs|IP Address'),
thClass: TABLE_HEADER_CLASSES,
},
{
key: 'date',
label: s__('AuditLogs|Date'),
thClass: TABLE_HEADER_CLASSES,
},
],
dateTimeFormat: LONG_DATE_FORMAT_WITH_TZ,
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment