Merge branch 'issue#325836-fix-empty-line-after-let-it-be-gitlab-analytics' into 'master'

Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/analytics

See merge request gitlab-org/gitlab!58245

.rubocop_manual_todo.yml

@@ -818,9 +818,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - spec/lib/gitlab/alert_management/payload/managed_prometheus_spec.rb
     - spec/lib/gitlab/alert_management/payload/prometheus_spec.rb
     - spec/lib/gitlab/alert_management/payload_spec.rb
-    - spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb
-    - spec/lib/gitlab/analytics/cycle_analytics/median_spec.rb
-    - spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb
     - spec/lib/gitlab/auth/otp/strategies/devise_spec.rb
     - spec/lib/gitlab/auth/otp/strategies/forti_authenticator_spec.rb
     - spec/lib/gitlab/auth/otp/strategies/forti_token_cloud_spec.rb

changelogs/unreleased/issue-325836-fix-empty-line-after-let-it-be-gitlab-analytics.yml

+---
+title: Fix EmptyLineAfterFinalLetItBe offenses in spec/lib/gitlab/analytics
+merge_request: 58245
+author: Huzaifa Iftikhar @huzaifaiftikhar
+type: fixed

spec/lib/gitlab/analytics/cycle_analytics/base_query_builder_spec.rb

@@ -7,6 +7,7 @@
   let_it_be(:mr1) { create(:merge_request, target_project: project, source_project: project, allow_broken: true, created_at: 3.months.ago) }
   let_it_be(:mr2) { create(:merge_request, target_project: project, source_project: project, allow_broken: true, created_at: 1.month.ago) }
   let_it_be(:user) { create(:user) }
+
   let(:params) { { current_user: user } }
   let(:records) do
     stage = build(:cycle_analytics_project_stage, {

spec/lib/gitlab/analytics/cycle_analytics/median_spec.rb

@@ -4,6 +4,7 @@
 RSpec.describe Gitlab::Analytics::CycleAnalytics::Median do
   let_it_be(:project) { create(:project, :repository) }
+
   let(:query) { Project.joins(merge_requests: :metrics) }
   let(:stage) do

spec/lib/gitlab/analytics/cycle_analytics/records_fetcher_spec.rb

@@ -34,6 +34,7 @@
     describe 'for issue based stage' do
       let_it_be(:issue1) { create(:issue, project: project) }
       let_it_be(:issue2) { create(:issue, project: project, confidential: true) }
+
       let(:stage) do
         build(:cycle_analytics_project_stage, {
           start_event_identifier: :plan_stage_start,