[ci skip]

[ci skip]

When `window.location.hash` is pointing to a note, e.g. `#note_1234`,
`scrollToElement` would throw an error because a selector such as
`.commits #note_1234` doesn't exist, so `offset()` returned `undefined`.

This error would prevent subsequent calls from running, which caused the
loading spinner to never be hidden.

Now we ensure the selector returns a valid element before trying to
scroll to it.

[ci skip]

Occasionally the loading spinner would stay visible after the tab
finished loading. This change makes the toggle explicit so that it's
always shown on `beforeSend`, and always hidden on `complete`.

Plus a bonus semi-colon eradication! 

Dmitriy Zaporozhets authored 9 years ago and Robert Speicher committed 9 years ago

Addresses regression with jenkins setup that does not use the multiproject setup

The Jenkins Gitlab Hook Plugin allows for two kinds of setups.  One where a Jenkins job is created for each branch and one where all branches are built in a single Jenkins job.  MR !9 added support for the multi-job setup but broke the single job setup.  This request addresses #30 and fixes the regression.

See merge request !27

Dmitriy Zaporozhets authored 9 years ago and Robert Speicher committed 9 years ago

Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>

Document known issue with Reply by email and multiple application servers.

See merge request !1499

Closes #2867

Bump Ruby and Golang versions

[ci skip]

See merge request !1467

Jacob Vosmaer (GitLab) authored 9 years ago and Robert Speicher committed 9 years ago

[ci skip]

Jacob Vosmaer (GitLab) authored 9 years ago and Robert Speicher committed 9 years ago

[ci skip]

[ci skip]

Closes #2692

[ci skip]

Dmitriy Zaporozhets authored 9 years ago and Robert Speicher committed 9 years ago

Fix bug where projects would appear to be stuck in the forked import state

A race condition existed between when Rails committed the `import_status` to
`started` and when the Sidekiq worker forked a project. If this fork were quick,
it's possible that the worker would attempt to move into the `finished` state
before the `started` state took effect.

As mentioned in https://github.com/mperham/sidekiq/wiki/Problems-and-Troubleshooting#cannot-find-modelname-with-id12345,
we can either delay the worker to ensure the DB has a chance to update, or use the nice `after_commit_queue` gem to schedule the task after the state machine commit. See:

* https://github.com/pluginaweek/state_machine/issues/191 
* https://github.com/shellycloud/after_commit_queue


Closes #2736

See merge request !1434

Dmitriy Zaporozhets authored 9 years ago and Robert Speicher committed 9 years ago

Fix Slack notification URL and remove the usage of Ci::RoutesHelper

Fix for #2644

See merge request !1391

[ci skip]