New icons related to issues

mentioned in issue gitlab-foss#32894 (closed)

changed the description

Please let me know if you have any thoughts, thanks!

I REALLY like the smiley faces. You packed so much personality into those!

I think you may have the wrong 'todo-done' for the current icon.

At first I wasn't sure about the thickness, they still feel very similar to the font-awesome icons in that regard. Then I compared these new icons with the illustrations and I can see the parity you are going for.

Since we are moving to straight svg versus icon fonts, we are not bound to just one color. Maybe there is an opportunity to add some personality through slight color variation.

@sarrahvesselov wouldn't multiple colors per icon make changing the color via CSS more difficult? It's super easy to change the fill when they're one color.

Most icons are pretty small and I'm not sure multiple colors would be worth the extra dev trouble.

@tauriedavis no, I have not found it to be more difficult at all, it just uses the fill property in the css. Classes applied to the path take care of the color, here is an example. I am talking about 4 colors maximum for the icon's static and active state. Four classes take care of it all.

Just a thought for adding more personality to our interface with little effort. Icons are small but add up across the application in terms of weight and presence.

Yeah, totally understand the technical part. I just meant it's more code and colors to manage. But if it's worth it, cool. I'll leave that up to you and Hazel!

Cool stuff @hazelyang !! I love the todo icons.

I worry about the smiley's though, as the mouth is i think to small. I rather go for a bigger mouth, which is instantly recognisable without squinting, as we have some animation going. the placement of the mouth makes it very adorable though, so in that sense

In order to gauge visual weight, i think you should provide a grid view of all icons :) wdyt?

color variation sounds cool to me, although i would suggest a focus on "slight color variation", as to not confuse with emoticons

mentioned in issue gitlab-foss#32411 (moved)

changed the description

I think you may have the wrong 'todo-done' for the current icon.

@sarrahvesselov Thanks! Updated it.

@sarrahvesselov @tauriedavis @dimitrieh

About slight color variation, it also sounds good to me. I'll experiment it on other icons. Thanks!

@dimitrieh You are right. The mouth should be bigger. The original mouth is not so obvious as the icon is small.

In order to gauge visual weight, i think you should provide a grid view of all icons :) wdyt?

Good idea. Will add the grid.

@hazelyang i see you created notifications icons. how do you see them working on the issue list?

we don't want to show notifications-off icon by default there correct?

This

is a standard RSS icon that is being used everywhere including GitLab.

I want to leave this comment just as a reminder to not replace that icon on RSS links with the new one.

Love these! Especially the smiley face

@dimitrieh @blackst0ne Thanks for bringing up this question! I think the icon for RSS will not be changed since it's a different action from the Subscribe action on the issue sidebar.

Discussion: Maybe when mousing over these 3 icons, we can have them has the background color?

@hazelyang how would you replace the subscribe buttons not in the sidebar in that case?

Maybe when mousing over these 3 icons, we can have them has the background color?

@hazelyang Slight variation on that: do that when in focus ? prob needs its own issue, will you create that? :)

mentioned in issue gitlab-foss#33677 (moved)

how would you replace the subscribe buttons not in the sidebar in that case?

The one we are using for RSS. (Did I answer your question? )

Slight variation on that: do that when in focus ? prob needs its own issue, will you create that? :)

Sure, created it (gitlab-foss#33677 (moved)).

@hazelyang do the notifications need to be in “3D”? They have a small rounding that gives them a bit of perspective, and the other icons don't have that. Maybe you have a rationale for this

@pedroms Thanks for mentioning this. I just did that intuitively. But I think they should be consistent with others icons. Will update these two icons in the description.