Code Climate data: how to interpret?
I'm not quite sure how to interpret this data in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/12253 when I didn't touch any JavaScript:
/cc: @dzaporozhets
Designs
- Show closed items
Relates to
- gitlab-foss #3617210.4
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Developer
@stanhu i am closing this in favor of https://gitlab.com/gitlab-org/gitlab-ee/issues/2548
- Dimitrie Hoekstra closed
closed
- username-removed-444 reopened
reopened
- Owner
@stanhu I think it happened because you merged master into your branch. Code quality tool compare BASE vs HEAD. So you added all those commits from master into HEAD while BASE of the merge request left the same. I believe this can be improved by looking for new BASE commit for code quality comparison every time merge request is updated
1 - Owner
@stanhu thanks for noticing this. Should be fixed/improved
- username-removed-444 changed milestone to %9.4 in gitlab-foss
changed milestone to %9.4 in gitlab-foss
- username-removed-444 assigned to @dzaporozhets
assigned to @dzaporozhets
- username-removed-444 mentioned in issue gitlab-foss#33897 (closed)
mentioned in issue gitlab-foss#33897 (closed)
- username-removed-444 removed assignee
removed assignee
- Owner
I unassigned because I am not working on this issue right now
- Mark Pundsack changed milestone to %Next 2-3 months in gitlab-foss
changed milestone to %Next 2-3 months in gitlab-foss
- Developer
@dzaporozhets Is this a duplicate of https://gitlab.com/gitlab-org/gitlab-ce/issues/36172 (which is scheduled for 10.2)?
- Owner
@winh this one is definitely a result of merging master in your branch while not sure about https://gitlab.com/gitlab-org/gitlab-ce/issues/36172. I believe person who will work on one of issues should take a look at another too
1 - Winnie Hellmann marked this issue as related to gitlab-foss#36172
marked this issue as related to gitlab-foss#36172
- Winnie Hellmann mentioned in issue gitlab-foss#36172
mentioned in issue gitlab-foss#36172
- Felipe Artur moved from gitlab-foss#33901 (moved)
moved from gitlab-foss#33901 (moved)