Wording for "Allowed to push" dropdown is confusing

Resources

UX @cperessini

---

Problem

In EE we allow specific people to be selected for the "Allowed to push" setting of protected branches. This can lead to confusion when you select both "No one" and a specific user:

Pop quiz: which setting gets precedent here?

Answer: Both! One applies to role, the other applies to a specific user.

I think the setting should probably say "No roles" or something like that.

This is only unclear in EE but the setting should change in CE as well for consistency.

cc @cperessini

---

Solution

We break down the options into sections: "Roles", "Groups" and "Users". We also remove the "No one" option, since deselecting all options in the "Roles" section has the same effect.

EE

EE users can select roles as well as groups and individual users

CE

CE users can only select roles

@rspeicher It really is confusing. We should give a title to each sections so it's clearer what you're choosing.

"No roles" is better but it might not be the best. I can't come up with anything better, though. Do you have any suggestions @dimitrieh?

EE: Roles and users

CE: Only roles

@cperessini The user who created the support ticket that originally prompted this issue makes a good point - why do we need "No one" at all? Isn't that essentially the same thing as not clicking either of the other two options? I guess it makes it more explicit, which is usually good, but leads to confusion in this case.

@cperessini I agree with @rspeicher here :)

That way it would work the same as assigning labels for instance, you either select them or you don't.

Apart from that, pretty good imo!

assigned you as you are working on it ;)

Reassigned to @cperessini

@rspeicher @dimitrieh You're right, it did seem a little weird. I think it must have been included originally in order to treat these options if these were radio buttons, and show people that it's possible to select no roles. But I think it's pretty clear that you can deselect all roles to achieve the same effect, so we should remove it.

@dimitrieh Thanks for that :)

New designs

EE

CE

EE with search for users

I'm not sure if search is both for roles and users, but I thought it might be only for users. In that case, we should move the search field to the Users section.

CE without search

There would be no search in CE

@rspeicher Do you know which is right?

@cperessini this uses the same design as the current filter dropdowns not? I think the "titles" are not necessary perse

@dimitrieh I think the case of the filters is a little different. When you filter by author you are given a choice between "Any author" or a specific author, so they both refer to the entity "author".

In this instance you are choosing between "roles" and "users", which are different types of entities. I feel the titles makes it clearer for someone who's new to using this feature, but I see your point.

Added ~113221 label

Support request: https://gitlab.zendesk.com/agent/tickets/49710

@cperessini don't mind my last comment in that case! I completely agree with you. I was just wondering if we already use this design pattern somewhere... and it was itching my mind, but I have found it:

In that sense I think these "subtitles" should be consistent in their design

@dimitrieh I like my style better

@cperessini let's go with yours! but change it for these as well?

@cperessini What is the status here?

changed milestone to %8.16

added frontend and removed ~126459 labels

@DouweM Updated the issue description with the final design.

@victorwu Can you help with scheduling for FE/BE if necessary? Thanks!

removed assignee

@dimitrieh Created https://gitlab.com/gitlab-org/gitlab-ce/issues/26202 for updating the rest of our dropdowns

added ~481018 label

Sure @cperessini . This looks like something @DouweM can prioritize and he's already put it in 8.16. If we don't get to it within 8.16, we'll see where go from there. Thanks!

styling is being taken care of in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/8402

changed milestone to %8.17

@victorwu This looks like Frontend to me :) /cc @jschatz1

removed ~481018 label

@iamphill what do you think the effort is here?

@iamphill if the effort is small can you just grab it super quick? If not we can see who has the free time. @victorwu this is not in the 8.17 meta issue which is what I generally go off of. If you want us to do it can you put it there.

assigned to @iamphill

mentioned in merge request !1114 (merged)

@DouweM + @jschatz1 : I was wondering if this is a platform thing. Going forward we have @mydigitalself from a product perspective to help us. But I see @iamphill already got this in quickly. Thanks Phil!

@victorwu only backend is currently platform or other classifications. On frontend we do it all no matter what the classification.

@victorwu @iamphill what is the state of updating the documentation for this issue?

mentioned in issue gitlab-com/gitlab-docs#69 (closed)

changed milestone to %9.0

closed via merge request !1114 (merged)