Elasticsearch Settings assume HTTP, need HTTPS too

With Elasticsearch set at 443 I am running “sudo gitlab-rake gitlab:elastic:create_empty_index” and getting a 400 errror.

I wanted to see what the next command would throw so I ran “sudo gitlab-rake gitlab:elastic:index_repositories” and that gave me the more accurate error:

`(Elasticsearch::Transport::Transport::Errors::BadRequest)

400 The plain HTTP request was sent to HTTPS port`

then I looked at Gitlab’s code:

self.__elasticsearch__.client = Elasticsearch::Client.new(
host: Gitlab.config.elasticsearch.host,
port: Gitlab.config.elasticsearch.port
)

It looks like there is nothing for https.

We need HTTPS for our set up.

added ~113221 label

added elasticsearch label

customer requested this here: https://gitlab.zendesk.com/agent/tickets/51761

Yes, we should be able to specify the schema https://github.com/elastic/elasticsearch-ruby/tree/master/elasticsearch-transport#authentication

mentioned in issue #1186

mentioned in issue #1181 (closed)

added feature proposal label

I'd very much like to fix this for 9.0... so do we want to solve this by introducing a use_ssl boolean column alongside host and port, or should we migrate to a url column instead? Thoughts @vsizov ?

changed milestone to %9.0

assigned to @nick.thomas

I think use_ssl boolean column is more convenient and we don't need to migrate existing data in this case.

mentioned in merge request !1220 (closed)

!1251 (closed) related. http/https + aws_signers_v4 for AWS Elasticsearch service.

This will be solved (using URLs rather than elasticsearch_ssl) in !1305 (merged)

OK, !1305 (merged) is merged.

closed