Skip to content
Snippets Groups Projects
New issue look: Off

Broken master

    • Closed Issue created by username-removed-128633 @rymai

    As seen in https://gitlab.com/gitlab-org/gitlab-ee/builds/9346406:

      1) Create New Merge Request when approvals are enabled for the target project saving the MR shows the saved MR
     Failure/Error: expect(page).to have_link('Close merge request')
       expected to find link "Close merge request" but there were no matches
     # ./spec/features/merge_requests/create_new_mr_spec.rb:61:in `block (4 levels) in <top (required)>'

Finished in 15 minutes 12 seconds (files took 16.53 seconds to load)
767 examples, 1 failure

Failed examples:

rspec ./spec/features/merge_requests/create_new_mr_spec.rb:57 # Create New Merge Request when approvals are enabled for the target project saving the MR shows the saved MR

    Designs

      Child items ...

      2. Activity

      • username-removed-128633
        username-removed-128633 @rymai ·
        Author Maintainer

        And also, as seen in https://gitlab.com/gitlab-org/gitlab-ee/builds/9346419:

          1) Merge request approvals Group approvers when creating an MR allows setting groups as approvers
     Failure/Error: find('.approvals-components')

     Capybara::ElementNotFound:
       Unable to find css ".approvals-components"
     # ./spec/features/merge_requests/approvals_spec.rb:79:in `block (4 levels) in <top (required)>'

  2) Merge request approvals Group approvers when creating an MR allows delete approvers group when it is set in project
     Failure/Error: page.evaluate_script('jQuery.active').zero?

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       ReferenceError: Can't find variable: jQuery
       ReferenceError: Can't find variable: jQuery
           at undefined:1
           at :1
           at :1
     # ./spec/support/wait_for_ajax.rb:9:in `finished_all_ajax_requests?'
     # ./spec/support/wait_for_ajax.rb:4:in `block in wait_for_ajax'
     # ./spec/support/wait_for_ajax.rb:3:in `wait_for_ajax'
     # ./spec/features/merge_requests/approvals_spec.rb:100:in `block (4 levels) in <top (required)>'

  3) Merge request approvals Group approvers when editing an MR with a different author allows setting groups as approvers
     Failure/Error: page.evaluate_script('jQuery.active').zero?

     Capybara::Poltergeist::JavascriptError:
       One or more errors were raised in the Javascript code on the page. If you don't care about these errors, you can ignore them by setting js_errors: false in your Poltergeist configuration (see documentation for details).

       ReferenceError: Can't find variable: jQuery
       ReferenceError: Can't find variable: jQuery
           at undefined:1
           at :1
           at :1
     # ./spec/support/wait_for_ajax.rb:9:in `finished_all_ajax_requests?'
     # ./spec/support/wait_for_ajax.rb:4:in `block in wait_for_ajax'
     # ./spec/support/wait_for_ajax.rb:3:in `wait_for_ajax'
     # ./spec/features/merge_requests/approvals_spec.rb:131:in `block (4 levels) in <top (required)>'

  4) Merge request approvals Group approvers when editing an MR with a different author allows delete approvers group when it`s set in project
     Failure/Error: find('.approvals-components')

     Capybara::ElementNotFound:
       Unable to find css ".approvals-components"
     # ./spec/features/merge_requests/approvals_spec.rb:153:in `block (4 levels) in <top (required)>'

  5) Merge request approvals Group approvers when editing an MR with a different author allows changing approvals number
     Failure/Error: find('.approvals-components')

     Capybara::ElementNotFound:
       Unable to find css ".approvals-components"
     # ./spec/features/merge_requests/approvals_spec.rb:163:in `block (4 levels) in <top (required)>'

  6) Merge request approvals Approving by approvers from groups when group is assigned to a project I am able to approve
     Failure/Error:
       page.within '.mr-state-widget' do
         click_button 'Approve Merge Request'
       end

     Capybara::ElementNotFound:
       Unable to find css ".mr-state-widget"
     # ./spec/features/merge_requests/approvals_spec.rb:245:in `approve_merge_request'
     # ./spec/features/merge_requests/approvals_spec.rb:210:in `block (4 levels) in <top (required)>'

  7) Merge request approvals Approving by approvers from groups when group is assigned to a project I am able to unapprove
     Failure/Error:
       page.within '.mr-state-widget' do
         click_button 'Approve Merge Request'
       end

     Capybara::ElementNotFound:
       Unable to find css ".mr-state-widget"
     # ./spec/features/merge_requests/approvals_spec.rb:245:in `approve_merge_request'
     # ./spec/features/merge_requests/approvals_spec.rb:216:in `block (4 levels) in <top (required)>'

  8) Merge request approvals Approving by approvers from groups when group is assigned to a merge request I am able to approve
     Failure/Error:
       page.within '.mr-state-widget' do
         click_button 'Approve Merge Request'
       end

     Capybara::ElementNotFound:
       Unable to find css ".mr-state-widget"
     # ./spec/features/merge_requests/approvals_spec.rb:245:in `approve_merge_request'
     # ./spec/features/merge_requests/approvals_spec.rb:229:in `block (4 levels) in <top (required)>'

  9) Merge request approvals Approving by approvers from groups when group is assigned to a merge request I am able to unapprove
     Failure/Error:
       page.within '.mr-state-widget' do
         click_button 'Approve Merge Request'
       end

     Capybara::ElementNotFound:
       Unable to find css ".mr-state-widget"
     # ./spec/features/merge_requests/approvals_spec.rb:245:in `approve_merge_request'
     # ./spec/features/merge_requests/approvals_spec.rb:236:in `block (4 levels) in <top (required)>'

Finished in 48 minutes 38 seconds (files took 22.42 seconds to load)
940 examples, 9 failures

Failed examples:

rspec ./spec/features/merge_requests/approvals_spec.rb:65 # Merge request approvals Group approvers when creating an MR allows setting groups as approvers
rspec ./spec/features/merge_requests/approvals_spec.rb:83 # Merge request approvals Group approvers when creating an MR allows delete approvers group when it is set in project
rspec ./spec/features/merge_requests/approvals_spec.rb:116 # Merge request approvals Group approvers when editing an MR with a different author allows setting groups as approvers
rspec ./spec/features/merge_requests/approvals_spec.rb:136 # Merge request approvals Group approvers when editing an MR with a different author allows delete approvers group when it`s set in project
rspec ./spec/features/merge_requests/approvals_spec.rb:157 # Merge request approvals Group approvers when editing an MR with a different author allows changing approvals number
rspec ./spec/features/merge_requests/approvals_spec.rb:209 # Merge request approvals Approving by approvers from groups when group is assigned to a project I am able to approve
rspec ./spec/features/merge_requests/approvals_spec.rb:215 # Merge request approvals Approving by approvers from groups when group is assigned to a project I am able to unapprove
rspec ./spec/features/merge_requests/approvals_spec.rb:228 # Merge request approvals Approving by approvers from groups when group is assigned to a merge request I am able to approve
rspec ./spec/features/merge_requests/approvals_spec.rb:235 # Merge request approvals Approving by approvers from groups when group is assigned to a merge request I am able to unapprove
      • username-removed-128633 added ~874214 label

        added ~874214 label

      • username-removed-128633 mentioned in merge request !1135 (merged)

        mentioned in merge request !1135 (merged)

      • username-removed-128633 closed via merge request !1135 (merged)

        closed via merge request !1135 (merged)

      • username-removed-128633 reopened

        reopened

      • username-removed-128633
        username-removed-128633 @rymai ·
        Author Maintainer

        @jarka or @brycepj I see that you're the last ones to have edited spec/features/merge_requests/approvals_spec.rb, could you have a look at the failures? Thanks in advance! :heart:

      • Jarka Kadlecova
        Jarka Kadlecova @jarka ·
        Maintainer

        @rymai I ran spec/features/merge_requests/approvals_spec.rb multiple times locally. I didn't get any of those errors however it behaves strangely. I can investigate further but will need to leave soon today.

        It can be a local problem only or something really simple but I am leaving here what fails for me locally in case someone will look into it:

        Failed examples:

rspec ./spec/features/merge_requests/approvals_spec.rb:83 # Merge request approvals Group approvers when creating an MR allows delete approvers group when it is set in project
rspec ./spec/features/merge_requests/approvals_spec.rb:162 # Merge request approvals Group approvers when editing an MR with a different author allows changing approvals number

        Problem:

             Failure/Error:
       User.
         active.
         where("(#{wheres.join(' OR ')}) AND id NOT IN (#{approvals.select(:user_id).to_sql})").
         where.not(id: author.id).
         count

     ActionView::Template::Error:
       undefined method `id' for nil:NilClass
     # ./app/models/concerns/approvable.rb:58:in `number_of_potential_approvers'
     # ./app/models/concerns/approvable.rb:19:in `approvals_left'
     # ./app/models/concerns/approvable.rb:10:in `approved?'
     # ./app/views/projects/merge_requests/widget/_open.html.haml:4:in

        However when I run just one example it is ok.

        Also (from number_of_potential_approvers in models/concerns/approvable.rb):

         author_id
=> 3
[15] pry(#<MergeRequest>)> author
=> nil
[16] pry(#<MergeRequest>)> User.find 3
=> #<User id: 3, email: "janay_orn@conn.biz", created_at: "2017-01-27 17:24:28", updated_at: "2017-01-27 17:24:29", name: "Zandra Cronin", admin: false, p
      • username-removed-408230
        username-removed-408230 @brycepj ·
        Contributor

        @rymai 's errors look like like the web driver isn't waiting long enough for the approvals ajax request to render on the page.

        @jarka I have no idea what's going on there. Maybe @jneen would have an idea?

      • Nick Thomas
        Nick Thomas @nick.thomas ·
        Maintainer 
        undefined method 'id' for nil:NilClass
app/models/concerns/approvable.rb:58

        In last Thursday's CE upstream merge, I included a fix for this error: https://gitlab.com/gitlab-org/gitlab-ee/commit/f87e887d6d3f2baef73a7f29825e64e152cc9652

        https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1161

        I also encountered numerous problems with approvals and squash ajax, which turned out to be caused by a bad merge on my part. There's now a timeout: https://gitlab.com/gitlab-org/gitlab-ee/commit/d57ae2259e696fc1bc1f8a19b56b965074b5a592

        So perhaps everything here is fixed? Or maybe it needs looking at more?

      • username-removed-128633
        username-removed-128633 @rymai ·
        Author Maintainer

        @nick.thomas Thanks! Let's close this for now, masters seem to be green again.

      • username-removed-128633 closed

        closed

      Please register or sign in to reply