Show project names for commit search results with Elasticsearch global search

Description

Currently, doing a global search for code shows the corresponding project name. For commits, that piece of information is missing so the user isn't able to distinguish commits from project to project.

Proposal

Stay consistent with the issues search results and add the namespace/project reference under the committer info:

cc @mydigitalself @victorwu

For reference, could you please add a screenshot of the Code view @vsizov?

added ~481018 label

changed title from Elasticsearch global search should group commits by project just like we do for code. to Elasticsearch global search should show project names on commits result page just like we do for code.

@mydigitalself Updated the issue. Thanks.

added ~113221 label

ZD https://gitlab.zendesk.com/agent/tickets/67003

added ~1035178 label

added shortlist label

Any updates on this issue ?

Right now we're just re-using the project commit partial, so unconditionally adding it would be a bit strange. Do we just want it to look something like:

[ avatar ] GitLab Org / GitLab Test: Add Fuubar
[        ] Robert Speicher committed a year ago

?

I'm not sure how much sense it makes to visually group by project - how would we reconcile that grouping with the search result scoring?

Yeah, we're reusing the template from regular commit search, but it's not intended to be used for a global search. So I'm not certain about how it should look like but it should be clear where exactly any particular commit has been found.

@mydigitalself There are a few ES ones that could be great coupled together as a concerted push. Support would love this prioritized :)

changed milestone to %9.3

@mydigitalself I think this needs some UX work!

@DouweM will this require ~Frontend too?

@mydigitalself Depending on how complex the UX turns out, possibly. But if it's just a simple label added somewhere, probably not.

added Deliverable label

@pedroms Are you able to pick up this one for 9.3?

assigned to @pedroms

Let's stay consistent with the issues search results and add the namespace/project reference under the committer info:

Is this one UX Ready @pedroms?

changed title from Elasticsearch global search should show project names on commits result page just like we do for code. to Show project names for commit search results with Elasticsearch global search

changed the description

added UX ready feature proposal and removed UX labels

@sarrahvesselov I was giving room for other participants to voice in, but since no one has done so, I've updated the description with my proposal

Perfect, thanks @pedroms!

changed milestone to %9.5

assigned to @tiagonbotelho

mentioned in merge request !2434 (merged)

closed via merge request !2434 (merged)