Auditor user to have separate feature license

Description

Audit capabilities are to be part of EE Premium. This was seemingly not entirely made clear in the scope of https://gitlab.com/gitlab-org/gitlab-ee/issues/1439 whereby the EE Premium tag was accidentally removed and not clarified how this should work.

Proposal

• The option to display Audit user in the user access permissions should only be visible if the license feature/product is available
• The license feature needs to be created in the payment system - please advise on existing naming conventions with existing paid "products"

Links / references

• https://gitlab.com/gitlab-org/gitlab-ee/issues/1439

This issue is a good example on the discussion we need to have about licenses. In the future, Premium will have exclusive features that Starter does not have.

However, sales need the ability to turn off some premium features in order to decrease the price during a negociation.

That means we need to check two things:

1. is the feature only available in premium?
2. if that's the case, as I'm starter, does my license still allow me to use it?

Behind the scenes, Premium should be a package, and contain major features as "addons". Because these checks will evolve over time (once we'll add monetization to GitLab.com, or when we'll introduce Ultimate), I'd create a separate method that is responsible for checking the right to use features, instead of ifs all over the place.

@ruben @timothyandrew let's discuss how we can make this happen.

Thanks Regis, I think given the requirement to give sales flexibility, we should always see premium "features" as feature licenses/flags and then Premium is merely a bundle of those features that automatically produces a license with those features enabled. Sales can then create "custom" bundles by adding or removing features where appropriate.

cc @DouweM

A discussion has happened in Slack about this and it will continue in https://gitlab.com/gitlab-org/gitlab-ee/issues/1641 for a broader approach to this problem.

assigned to @timothyandrew

mentioned in merge request !998 (merged)

mentioned in issue gitlab-com/gitlab-docs#69 (closed)

This is implemented in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/998.

closed