Geo Nodes check is wasteful and unnecessary

When loading a MR page, I see this in the SQL dump:

D, [2017-02-03T00:55:27.989480 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:27.993192 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:27.996257 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:27.998179 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.000058 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.002917 #5857] DEBUG -- :   GeoNode Exists (1.3ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.005297 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.007064 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.008967 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.010682 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.013430 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.015619 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.017926 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.020557 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.022336 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.025462 #5857] DEBUG -- :   GeoNode Exists (1.4ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.029130 #5857] DEBUG -- :   GeoNode Exists (1.1ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.032230 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.035641 #5857] DEBUG -- :   GeoNode Exists (1.2ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.038542 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.042028 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.043890 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.045715 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.048203 #5857] DEBUG -- :   GeoNode Exists (1.2ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.049918 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.053180 #5857] DEBUG -- :   GeoNode Exists (1.1ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.055314 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.057399 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.059886 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.062118 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.064769 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.066473 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.068191 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.070547 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.072365 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.074684 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.076632 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.081458 #5857] DEBUG -- :   GeoNode Exists (3.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.083817 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.085933 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.087694 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.089520 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.091622 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.094487 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.096932 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.100260 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.103750 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.105425 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.130545 #5857] DEBUG -- :   GeoNode Exists (24.2ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.133046 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.135545 #5857] DEBUG -- :   GeoNode Exists (1.1ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.138134 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.141847 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.144750 #5857] DEBUG -- :   GeoNode Exists (1.6ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.146955 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.148610 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.150261 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.152879 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.154496 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.156469 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.158058 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.160619 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.165574 #5857] DEBUG -- :   GeoNode Exists (3.2ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.167338 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.169286 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.171169 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.173721 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.175526 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.177198 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.178871 #5857] DEBUG -- :   GeoNode Exists (0.7ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.181531 #5857] DEBUG -- :   GeoNode Exists (1.3ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.183510 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.187132 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.189259 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.191069 #5857] DEBUG -- :   GeoNode Exists (0.8ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.193739 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.195638 #5857] DEBUG -- :   GeoNode Exists (0.9ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.197536 #5857] DEBUG -- :   GeoNode Exists (1.0ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1
D, [2017-02-03T00:55:28.204645 #5857] DEBUG -- :   GeoNode Exists (6.2ms)  SELECT  1 AS one FROM "geo_nodes" LIMIT 1

This seems like we are burning lots of DB queries just to check Gitlab::Geo.geo_node?.

added ~164929 label

For loading issue 1 on GitLab CE, this repeated operation adds 3% into the load time:

/cc: @brodock

It looks like this is a problem with my method of profiling; RequestStore is off.

closed

reopened

mentioned in commit ed630d18

mentioned in merge request !1178 (merged)

mentioned in commit 6ec3953e

closed via commit 0150b04f

closed via commit 6ec3953ef9b2ed07559db1dbaa36cf80f77d5440

closed via merge request !1178 (merged)

mentioned in commit 8966c83e

mentioned in commit 138eb2a2