Add `repository_storage` and `approvals_before_merge` on `API::V3::Projects`

Re-add removed repository_storage and approvals_before_merge params from API::V3::Projects.

changed title from Re-add repository_storage and approvals_before_merge on API::V3::Projects to Add repository_storage and approvals_before_merge on API::V3::Projects

@oswaldo We should actually double check all the endpoint in lib/api/v3.

Out of curiosity, how did this get removed? Was this due to a bad merge?

@stanhu Also trying to figure this out.

assigned to @oswaldo

@eReGeBe found it here https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7456

mentioned in merge request !1209 (merged)

Actually, I might've been wrong to point to that MR, since it's on CE. I think now the problem was when fixing the conflicts on EE, we omitted the things that @oswaldo's MR is adding (see https://gitlab.com/gitlab-org/gitlab-ee/commit/0b64b73affafafdabeb3c09b53b85eb6f647274d)

The real problem is that there isn't a spec that tests the functionality of those params in those endpoints.

@oswaldo @eReGeBe is this something we can get fixed and pulled into an RC rather quickly?

There are storage changes that cannot take place while the API is broken in this fashion.

@northrup /v4/* namespace is working correctly in this fashion, but I think it isn't gonna help by now. @eReGeBe Is there a way ship this right after the build finishes?

@stanhu Not sure it was written down somewhere already. But just for future reference.

During the implementation of API v4 we copy the original v3 implementation to the v3 subdir. This is done in CE. But during the merge to EE, just a new file is added and no merge conflict is indicated. So the merger is not alarmed EE changes done in lib/api/projects.rb also should be copied to lib/api/v3/projects.rb.

closed via merge request !1209 (merged)