Push rules broken when using git 2.11.x
Upgrading to git 2.11.x breaks the push rules. This is reproducible with both the max file size and member check push rules. I didn't test any of the others.
remote: GitLab: API is not accessible
To git@<gitlab>:cms/test-repo.git
! [remote rejected] new-branch-1 -> new-branch-1 (pre-receive hook declined)
error: failed to push some refs to 'git@<gitlab>:cms/test-repo.git'
And in the production.log:
Started POST "/api/v3/internal/allowed" for 127.0.0.1 at 2017-02-15 17:43:34 +0100
NoMethodError (undefined method `safe_message' for nil:NilClass):
/data/git/gitlab/lib/gitlab/checks/change_access.rb:105:in `block in push_rule_check'
/data/git/gitlab/lib/gitlab/checks/change_access.rb:104:in `each'
/data/git/gitlab/lib/gitlab/checks/change_access.rb:104:in `push_rule_check'
/data/git/gitlab/lib/gitlab/checks/change_access.rb:19:in `exec'
/data/git/gitlab/lib/gitlab/git_access.rb:199:in `check_single_change_access'
/data/git/gitlab/lib/gitlab/git_access.rb:176:in `block in check_change_access!'
/data/git/gitlab/lib/gitlab/changes_list.rb:12:in `each'
/data/git/gitlab/lib/gitlab/changes_list.rb:12:in `each'
/data/git/gitlab/lib/gitlab/git_access.rb:175:in `check_change_access!'
/data/git/gitlab/lib/gitlab/git_access.rb:154:in `check_push_access!'
/data/git/gitlab/lib/gitlab/git_access.rb:45:in `check'
/data/git/gitlab/lib/api/internal.rb:44:in `block (2 levels) in <class:Internal>'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:59:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:59:in `block (2 levels) in generate_api_method'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:166:in `instrument'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:58:in `block in generate_api_method'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:264:in `block in run'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:166:in `instrument'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:238:in `run'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:310:in `block in build_stack'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/base.rb:30:in `call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/base.rb:23:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/base.rb:30:in `call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/base.rb:23:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-oauth2-1.2.3/lib/rack/oauth2/server/resource.rb:20:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-oauth2-1.2.3/lib/rack/oauth2/server/resource/bearer.rb:8:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/error.rb:34:in `block in call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/error.rb:33:in `catch'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/error.rb:33:in `call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/middleware/base.rb:23:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/head.rb:13:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:222:in `call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/endpoint.rb:216:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/router/route.rb:68:in `exec'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/router.rb:71:in `block in identity'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/router.rb:92:in `transaction'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/router.rb:67:in `identity'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/router.rb:52:in `block in call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/router.rb:115:in `with_optimization'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/router.rb:51:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/api.rb:119:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/api.rb:45:in `call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/grape-0.18.0/lib/grape/api.rb:40:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/routing/mapper.rb:51:in `serve'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/journey/router.rb:43:in `block in serve'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/journey/router.rb:30:in `each'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/journey/router.rb:30:in `serve'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/routing/route_set.rb:817:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/omniauth-1.3.2/lib/omniauth/strategy.rb:403:in `call_app!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/omniauth-saml-1.7.0/lib/omniauth/strategies/saml.rb:135:in `other_phase'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/omniauth-1.3.2/lib/omniauth/strategy.rb:185:in `call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/omniauth-1.3.2/lib/omniauth/strategy.rb:164:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/omniauth-1.3.2/lib/omniauth/strategy.rb:186:in `call!'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/omniauth-1.3.2/lib/omniauth/strategy.rb:164:in `call'
/data/git/gitlab/lib/gitlab/middleware/multipart.rb:93:in `call'
/data/git/gitlab/lib/gitlab/request_profiler/middleware.rb:15:in `call'
/data/git/gitlab/lib/gitlab/middleware/go.rb:16:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/warden-1.2.6/lib/warden/manager.rb:35:in `block in call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/warden-1.2.6/lib/warden/manager.rb:34:in `catch'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/warden-1.2.6/lib/warden/manager.rb:34:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-cors-0.4.0/lib/rack/cors.rb:80:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-attack-4.4.1/lib/rack/attack.rb:107:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/etag.rb:24:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/conditionalget.rb:38:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/head.rb:13:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
/data/git/gitlab/lib/gitlab/middleware/readonly_geo.rb:29:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/flash.rb:260:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/session/abstract/id.rb:225:in `context'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/session/abstract/id.rb:220:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/cookies.rb:560:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/query_cache.rb:36:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.7.1/lib/active_record/connection_adapters/abstract/connection_pool.rb:653:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:88:in `__run_callbacks__'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:778:in `_run_call_callbacks'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/remote_ip.rb:78:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.7.1/lib/rails/rack/logger.rb:38:in `call_app'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.7.1/lib/rails/rack/logger.rb:20:in `block in call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `block in tagged'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:26:in `tagged'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `tagged'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.7.1/lib/rails/rack/logger.rb:20:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/request_store-1.3.1/lib/request_store/middleware.rb:9:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/actionpack-4.2.7.1/lib/action_dispatch/middleware/request_id.rb:21:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/methodoverride.rb:22:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/runtime.rb:18:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/lock.rb:17:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/sendfile.rb:113:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/sentry-raven-2.0.2/lib/raven/integrations/rack.rb:50:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.7.1/lib/rails/engine.rb:518:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.7.1/lib/rails/application.rb:165:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.7.1/lib/rails/railtie.rb:194:in `public_send'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/railties-4.2.7.1/lib/rails/railtie.rb:194:in `method_missing'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/urlmap.rb:66:in `block in call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/urlmap.rb:50:in `each'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/rack-1.6.5/lib/rack/urlmap.rb:50:in `call'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:562:in `process_client'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-worker-killer-0.4.4/lib/unicorn/worker_killer.rb:52:in `process_client'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:658:in `worker_loop'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:508:in `spawn_missing_workers'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/lib/unicorn/http_server.rb:132:in `start'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/gems/unicorn-5.1.0/bin/unicorn_rails:209:in `<top (required)>'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/bin/unicorn_rails:23:in `load'
/data/git/gitlab/vendor/bundle/ruby/2.3.0/bin/unicorn_rails:23:in `<top (required)>'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/cli/exec.rb:74:in `load'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/cli/exec.rb:74:in `kernel_load'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/cli/exec.rb:27:in `run'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/cli.rb:335:in `exec'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/cli.rb:20:in `dispatch'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/cli.rb:11:in `start'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/exe/bundle:32:in `block in <top (required)>'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
/usr/local/lib/ruby/gems/2.3.0/gems/bundler-1.14.2/exe/bundle:24:in `<top (required)>'
/usr/local/bin/bundle:22:in `load'
/usr/local/bin/bundle:22:in `<main>'
We first noticed this with 8.14.x-ee (https://gitlab.com/gitlab-org/gitlab-ce/issues/25301), but this still occurs with 8.16.5-ee.
Kind regards, Bartosz