Commits from non-gitlab users are identical to ones from gitlab users in UI, but behave differently
Summary
When committing on a commit, there's no way to know if the commit author will be alerted or not.
Steps to reproduce
- Two commits to a repo - commit 'a' where the author is a gitlab user, commit 'b' where the author is not a gitlab user
- Comment on both commits
What is the current bug behavior?
When you comment on commit 'a', an email is sent. (Correct.) When you comment on commit 'b', no email is sent.
In both cases, the UI looks exactly the same (unless you hover over the committers name to see that the email address, and are aware that the user logs into gitlab with a different email address or is not a gitlab user.)
This caused a several month long gitlab support ticket https://support.gitlab.com/hc/en-us/requests/47064 as we were getting users apparently randomly not receiving emails whilst other users received emails fine.
What is the expected correct behavior?
-
Commits from non-gitlab users should be clearly flagged in the UI - eg. a badge saying 'Not a gitlab user'.
-
When you comment on a commit, the UI should clearly show who the comment will / has been sent to.
-
If the commit author isn't a gitlab user, the user that pushed the commit to gitlab should probably be treated as the author when comments are made.
(We're going to set the 'Check whether author is a GitLab user' option in push rules in the repo settings to try and work around this.)
Results of GitLab environment info
Our instance is on githost.io so I can't run this. Version is GitLab Enterprise Edition 8.17.2-ee 474978de.
