DRY approval settings
Resources
FE @lbennett
Description
I have a Deliverable https://gitlab.com/gitlab-org/gitlab-ee/issues/1526 to slightly improve the project settings approval settings. This improvement was a part of a chain of improvements that I wasn't wholly aware of. I didn't read everything correctly and ended up implementing the full UX improvement design for the new/edit MR page approval settings. About half way through, talking to @victorwu, I realise I am working out of the scope of the issue. Instead of improving the MR page from scratch, I was meant to be improving on top of already merged changes to the project settings page.
So, we highlighted from this that the 2 approval settings have different implementations.
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1656 is the MR where I start to add the new design to the MR page. It uses droplab over select2 so is closer to our final desired implementation.
The MR page approval settings will get more use than the project settings so we should probably schedule the MR page to be updated with the new designs (i.e. completing https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/1656) and then one last MR to DRY the 2 implementations, thus removing the use of select2 from the project settings.
Dependencies
Do this first, which is re-designing the merge request web form: https://gitlab.com/gitlab-org/gitlab-ee/issues/2228
Scope of work to be done in this issue
- The existing approvals settings in the project settings and the merge request web form has shared UI and functionality. We fix some tech debt and make it DRY.