[BUG] Incorrect calculation when entering license for 100 active users

I just added the license we purchased for GitLab EE. We purchased 10 license packs for a total of 100 users. We happen to have exactly 100 users. After entering the license key, I got this error message.

During the year before this license started, this GitLab installation had 100 active users, exceeding this license's limit of 100 by 0 users. Please upload a license for at least 100 users.

Status changed to closed

@iheart2code this is probably due to an incorrectly generated license file. Please contact our sales department at sales@ to get a new one.

I've let them know. Haven't heard back yet. Thanks for the response.

mentioned in issue #235

I still think this has got to be a bug. This is the response I got from EE support.

I tested the licenses that have been generated on a test server and they are encoded properly, which means the problem is not with the license file.

I think #235 may be related.

Status changed to reopened

Confirmed by EE support:

It is a bug in the license seat calculation. It does a lower than instead of a lower or equals. So you had exactly 100 users active, the Historical data worker recorded that, and now that you blocked the remaining users the historical counter remained at 100. As you know 100 is not lower than 100, so the app throws an error.

@DouweM there seems to be a bug on the license seat calculation. For @iheart2code the license he purchased was for 100 users. Before upgrading to EE, he blocked some of his users to get the count down to 100. The problem is that the code checks for lower than instead of lower or equals. This causes a totally valid license to be rejected, thus the you exceed the number of seats by 0 error.

The code in question is: https://gitlab.com/gitlab-org/gitlab-ee/blob/master/app/models/license.rb#L105

This can be easily fixed, and should probably be included in a patch release.

cc @rspeicher

Added ~91797 label

Added ~113221 label

Reassigned to @rspeicher

mentioned in merge request !147 (merged)

Status changed to closed by commit 9f643ea2

mentioned in commit 9f643ea2

mentioned in commit 28301fe1

Thanks, everyone!

Hi, We have the same issue, I have send mail to your sales department and got no response. We tried to update GitLab on our server and delete few users, but still without any success!! We bought license for 10 users, and now we stuck. I'll appreciate you help ASAP. Thanks, David

@Manela I'm sorry about the inconvenience, you should get a response from our sales team soon.

@DouweM I'm sorry, It's almost 5 days sins you said that Sales department will be in touch with me. Still nothing. Our projects are stuck, and it makes us loosing expensive time. Please do your best to make someone be in touch with me ASAP.

@Manela :( I've pinged them again.

@Manela I have just reissued another license for 12 users which should resolve the issue. You will note that I have also extended the subscription period to 15th Feb 2017. I apologise for the inconvenience. Any issues please let me know.

Dear @richardp , Thanks for your response. The license works!!! :) Very happy to be one of your customers.

Mentioned in commit pfjason/gitlab-ce@9f643ea2

Mentioned in commit pfjason/gitlab-ce@28301fe1