Namespace license checks for MR approvers

Related to https://gitlab.com/gitlab-org/gitlab-ee/issues/2335

Merge requests approvers (EES / Bronze)

1. Do not display Approvals required and Reset approvals on push options on the project settings page.

2. How to handle for future cases where this has already been set?

Expert: @vsizov

@vsizov How much effort do you estimate it will take to find all places that touch MR approvers and add project.feature_available?(:merge_request_approvers) checks to them (both on frontend and backend), so that this feature can be turned off for a specific project in its entirety by having that method return false?

mentioned in issue #2335 (closed)

I think it's enough to return 0 from methods approvals_before_merge in MR and project models, like:

def approvals_before_merge
  return 0 unless project.feature_available?(:merge_request_approvers)

  super
end

assigned to @to1ne

@nick.thomas agreed to take over this one. Thanks!!! in

assigned to @nick.thomas and unassigned @to1ne

mentioned in merge request !2324 (merged)

closed via merge request !2324 (merged)

mentioned in commit 60fbb4bf

mentioned in issue #2501 (closed)