Namespace license checks for rebase MR before merge

Related to https://gitlab.com/gitlab-org/gitlab-ee/issues/2335

Rebase merge requests before merge (EES / Bronze)

1. Do not show Rebase from master button on a fast-forward merge request

2. Or show button but redirect to payment page

Experts: @dzaporozhets @vsizov

Related to https://gitlab.com/gitlab-org/gitlab-ee/issues/2571 and https://gitlab.com/gitlab-org/gitlab-ee/issues/2572

mentioned in issue #2571 (closed)

mentioned in issue #2572 (closed)

@dzaporozhets How much effort do you estimate it will take to find all places that touch MR rebase and add project.feature_available?(:merge_request_rebase) checks to them (both on frontend and backend), so that this feature can be turned off for a specific project in its entirety by having that method return false?

mentioned in issue #2335 (closed)

@DouweM not much. I believe it will be enough to do so in the controller and the view.

@DouweM who owns this? you, me or @vsizov ?

@dzaporozhets Me, and then whoever I ask to work on this for 9.4 :)

@DouweM ok so experts are mentioned for person who will work on issue to know who to contact

@dzaporozhets Yeah, sorry, could've been clearer about that.

assigned to @nick.thomas

mentioned in merge request !2200 (merged)

closed via merge request !2200 (merged)

mentioned in commit c44be0d3

I think I missed something in !2200 (merged)

Project#merge_method is EE-only and looks up the projects.merge_requests_rebase_enabled column to determine whether it should offer the rebase_merge strategy.

The brief is to have EE act like CE when a project feature isn't available. Currently, we provide a "rebase before merge" strategy that is in neither of CE or EE.

I'll create a follow-up MR to resolve this by removing the strategy entirely.

reopened

mentioned in merge request !2274 (closed)

closed

mentioned in merge request !2272 (merged)