Spec helper for license mocks

Description

For the namespace license checks we'll need some spec helper method to perform some mocks.

An example from a discussion in !2109 (merged):

allow(License).to receive(:feature_available?).and_call_original
allow(License).to receive(:feature_available?).with(:service_desk) { true }

Some other use cases might come up...

Proposal

Create LicenseHelper that contains a set of helpers to enable/disable licensed features

Related issues

#2335 (closed)

cc @nick.thomas @reprazent @DouweM

changed the description

added test label

@nick.thomas @reprazent @to1ne One of you, please create an MR for this sooner rather than later since it will make all of your lives easier :)

assigned to @to1ne

@lbennett has one in !2112 (merged) but we'll need a follow-up MR to convert everything to use it.

@nick.thomas Do you mean @godfat?

Yep, it looks like this:

module EE
  module LicenseHelpers
    def stub_feature(feature, enabled = true)
      allow_any_instance_of(License).to receive(:feature_available?)
        .and_call_original

      allow_any_instance_of(License).to receive(:feature_available?)
        .with(feature) { enabled }
    end
  end
end

And in spec/spec_helper.rb

  config.include EE::LicenseHelpers

Whoops, yes I did!

Step 1 would be to add the helper. Then we can use it for future specs. I think @reprazent is already working on an MR for this.

Step 2 would be to use the helper everywhere we can. But this is just technical debt, and has a low priority.

So unassiging myself right now.

removed assignee

mentioned in merge request !2220 (merged)

assigned to @reprazent

I'm happy to do the grunt work on step 2 :)

closed via merge request !2220 (merged)

Reopening for step 2

reopened

assigned to @nick.thomas and unassigned @reprazent

mentioned in merge request !2233 (merged)

closed via commit 68918387

reopened

mentioned in commit 68918387

closed via merge request !2233 (merged)

mentioned in commit 81313af3