Improve filtering for issue weight

Currently you can only select 'Any', which includes 'No'.

It should be:

any weight => all issues (assuming not == 0)

no weight => issues without weight set

..list of weights

/cc @JobV

Copied from https://gitlab.com/gitlab-org/gitlab-ce/issues/4234, as this is an EE only issue.

Thanks for moving @jameslopez

mentioned in merge request !172 (merged)

@JobV quick one as I'm about to submit a fix for this... For any weight => all issues (assuming not == 0), what do you mean by not zero ?

@jameslopez you can't set the weight to 0. So if you do any weight, it should only find issues that have the weight set.

TBH I didn't remember what I meant with that either ;)

@JobV Thanks! I actually thought you referred to that. But then looking at milestones for instance, it looks like when we select Any Milestone, issues with no milestone set also come up! So in my opinion, if we only show issues with a weight set, perhaps we have to change the behaviour for milestones, labels... Or the other way around

@jameslopez agree, the behavior of the other filters should change. We might want to add the option of Everything or All, so that if you select any and then want to go to see everything again, you can select something.

any > 0

no == 0

no filter >= 0

mentioned in issue #321 (closed)

@JobV Thanks! added a new issue for that: https://gitlab.com/gitlab-org/gitlab-ee/issues/321

Would this apply to Asignee as well?

Thanks!!

@jameslopez whatever makes sense! So, I'd say yes.

Milestone changed to 8.6

Status changed to closed by merge request !172 (merged)

mentioned in merge request !217 (closed)

mentioned in commit fbb011be

mentioned in commit e9af4c71

Mentioned in commit pfjason/gitlab-ce@8151efa5

Mentioned in commit fbb011be

Mentioned in commit e9af4c71